Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TS #2382

Merged
merged 5 commits into from
Sep 27, 2019
Merged

Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TS #2382

merged 5 commits into from
Sep 27, 2019

Conversation

pugnascotia
Copy link
Contributor

Summary

Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TypeScript.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

chandlerprall
chandlerprall suggested changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; requesting some changes around exports in the source files, some of which will need to be added to the corresponding index.ts files as well to ensure they're exported to the top module level

src/components/call_out/call_out.tsx Outdated Show resolved Hide resolved
src/components/facet/facet_group.tsx Outdated Show resolved Hide resolved
src/components/key_pad_menu/key_pad_menu.tsx Outdated Show resolved Hide resolved
src/components/key_pad_menu/key_pad_menu_item.test.tsx Show resolved Hide resolved
src/components/key_pad_menu/key_pad_menu_item.tsx Show resolved Hide resolved
src/components/key_pad_menu/key_pad_menu_item.tsx Outdated Show resolved Hide resolved
@pugnascotia pugnascotia force-pushed the oh-i-like-to-ts-migrate branch from 751ec9a to 97dc135 Compare September 27, 2019 10:25
@pugnascotia
Copy link
Contributor Author

Ready for another review pass.

thompsongl
thompsongl approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pugnascotia pugnascotia merged commit 8f6c260 into elastic:master Sep 27, 2019
@pugnascotia pugnascotia deleted the oh-i-like-to-ts-migrate branch September 27, 2019 14:24
@cchaos cchaos mentioned this pull request Sep 27, 2019
Merged
snide pushed a commit to snide/eui that referenced this pull request Oct 10, 2019
@pugnascotia @snide
Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TS (elas…
e93627e 
…tic#2382)

Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TypeScript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall requested changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
chore typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pugnascotia @chandlerprall @thompsongl