Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match button text alignment to card textAlign prop #2741

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

ryankeairns
Copy link
Contributor

Fixes #2740

Summary

While working in Canvas, I noticed that the title text for clickable cards was being centered. Seems like a regression, but regardless it's an easy fix.

Before

Screenshot 2020-01-07 14 16 19

After

textAlign: left
Screenshot 2020-01-07 14 37 34

textAlign: right
Screenshot 2020-01-07 14 45 23

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@ryankeairns ryankeairns marked this pull request as ready for review January 7, 2020 20:54
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryankeairns ryankeairns merged commit 90c1760 into elastic:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button text is centered on left- and right-aligned EuiCards
2 participants