Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighten hollow badge border in dark mode #2746

Merged
merged 4 commits into from
Jan 9, 2020

Conversation

ryankeairns
Copy link
Contributor

Fixes #2744

Summary

After the recent badge color update, the hollow badge border became hard to see in dark mode. This PR adds some tint to lighten the border when in dark mode. Similar to the light version, the border remains more subtle than the text.

Before

Screenshot 2020-01-08 17 21 34

After

Screenshot 2020-01-09 08 11 14

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@ryankeairns ryankeairns requested a review from cchaos January 9, 2020 14:15
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just looked at screenshot and code though. Seems straight forward.

CHANGELOG.md Outdated Show resolved Hide resolved
ryankeairns and others added 2 commits January 9, 2020 10:08
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase contrast of hollow label in dark mode
3 participants