Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyze event glyph to EuiIcon #3729

Merged
merged 9 commits into from
Jul 17, 2020
Merged

Add analyze event glyph to EuiIcon #3729

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5ed4768
adding analyze event security icon
marrasherrier Jul 13, 2020
c87d6f7
Merge branch 'master' into security-icons
marrasherrier Jul 13, 2020
d70f8e6
updating analyze_event icon
marrasherrier Jul 15, 2020
83c42af
Merge branch 'master' into security-icons
marrasherrier Jul 15, 2020
a98a5c3
updating again
marrasherrier Jul 15, 2020
87e7fd3
Update CHANGELOG.md
marrasherrier Jul 15, 2020
1844dea
update
marrasherrier Jul 16, 2020
238a0cf
Merge branch 'master' into security-icons
marrasherrier Jul 16, 2020
a0494e3
Merge branch 'master' into security-icons
marrasherrier Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `27.1.0`.
- Updated `analyzeEvent` glyph in `EuiIcon` ([#3729](https://github.com/elastic/eui/pull/3729))
marrasherrier marked this conversation as resolved.
Show resolved Hide resolved

## [`27.1.0`](https://github.com/elastic/eui/tree/v27.1.0)

Expand Down
1 change: 1 addition & 0 deletions src-docs/src/views/icon/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const iconTypes = [
'accessibility',
'aggregate',
'alert',
'analyzeEvent',
'annotation',
'apmTrace',
'apps',
Expand Down
74 changes: 74 additions & 0 deletions src/components/icon/__snapshots__/icon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,80 @@ exports[`EuiIcon props type alert is rendered 1`] = `
</svg>
`;

exports[`EuiIcon props type analyzeEvent is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
fill="none"
focusable="false"
height="16"
role="img"
viewBox="0 0 14 16"
width="14"
xmlns="http://www.w3.org/2000/svg"
>
<path
clip-rule="evenodd"
d="M13.924 4.013a.605.605 0 00-.228-.236L7.304.082a.607.607 0 00-.608 0L.304 3.777A.62.62 0 000 4.304v7.392c0 .217.116.418.304.527l6.392 3.695c.188.11.42.11.608 0l6.392-3.695a.609.609 0 00.304-.527V4.304a.607.607 0 00-.076-.291zM1 5.079v6.391l6 3.47 6-3.47V5.08L7.252 8.432 7 8.579l-.252-.147L1 5.079zm11.476-.852L7 1.06 1.524 4.227 7 7.42l5.476-3.194z"
fill="#000"
fill-rule="evenodd"
/>
</svg>
`;

exports[`EuiIcon props type analyzeEventDisabled is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
fill="none"
focusable="false"
height="16"
role="img"
viewBox="0 0 14 16"
width="14"
xmlns="http://www.w3.org/2000/svg"
>
<g
clip-path="url(#clip0)"
>
<path
clip-rule="evenodd"
d="M13.924 4.013a.605.605 0 00-.228-.236L7.304.082a.607.607 0 00-.608 0L.304 3.777A.62.62 0 000 4.304v7.392c0 .217.116.418.304.527l6.392 3.695c.188.11.42.11.608 0l6.392-3.695a.609.609 0 00.304-.527V4.304a.607.607 0 00-.076-.291zM7 14.939l6-3.469-3 1.735-3 1.734z"
fill="#D3DAE6"
fill-rule="evenodd"
/>
<g
clip-path="url(#clip1)"
>
<path
clip-rule="evenodd"
d="M13.924 4.013a.605.605 0 00-.228-.236L7.304.082a.607.607 0 00-.608 0L.304 3.777A.62.62 0 000 4.304v7.392c0 .217.116.418.304.527l6.392 3.695c.188.11.42.11.608 0l6.392-3.695a.609.609 0 00.304-.527V4.304a.607.607 0 00-.076-.291zM1 5.079v6.391l6 3.47 6-3.47V5.08L7.252 8.432 7 8.579l-.252-.147L1 5.079zm11.476-.852L7 1.06 1.524 4.227 7 7.42l5.476-3.194z"
fill="#98A2B3"
fill-rule="evenodd"
/>
</g>
</g>
<defs>
<clipPath
id="clip0"
>
<path
d="M0 0h14v16H0z"
fill="#fff"
/>
</clipPath>
<clipPath
id="clip1"
>
<path
d="M0 0h14v16H0z"
fill="#fff"
/>
</clipPath>
</defs>
</svg>
`;

exports[`EuiIcon props type annotation is rendered 1`] = `
<svg
aria-hidden="true"
Expand Down
19 changes: 19 additions & 0 deletions src/components/icon/assets/analyze_event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import React from 'react';

const EuiIconAnalyzeEvent = ({ title, titleId, ...props }) => (
<svg
width={14}
height={16}
viewBox="0 0 16 16"
xmlns="http://www.w3.org/2000/svg"
aria-labelledby={titleId}
{...props}>
{title ? <title id={titleId}>{title}</title> : null}
<path
fillRule="evenodd"
d="M13.924 4.013a.605.605 0 00-.228-.236L7.304.082a.607.607 0 00-.608 0L.304 3.777A.62.62 0 000 4.304v7.392c0 .217.116.418.304.527l6.392 3.695c.188.11.42.11.608 0l6.392-3.695a.609.609 0 00.304-.527V4.304a.607.607 0 00-.076-.291zM1 5.079v6.391l6 3.47 6-3.47V5.08L7.252 8.432 7 8.579l-.252-.147L1 5.079zm11.476-.852L7 1.06 1.524 4.227 7 7.42l5.476-3.194z"
/>
</svg>
);

export const icon = EuiIconAnalyzeEvent;
3 changes: 3 additions & 0 deletions src/components/icon/assets/analyze_event.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions src/components/icon/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ const typeToPathMap = {
advancedSettingsApp: 'app_advanced_settings',
aggregate: 'aggregate',
alert: 'alert',
analyzeEvent: 'analyze_event',
analyzeEventDisabled: 'analyze_event_disabled',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to delete this line as well for the old disabled icon.

annotation: 'annotation',
apmApp: 'app_apm',
apmTrace: 'apm_trace',
Expand Down