Add analyze event glyph to EuiIcon #3729

marrasherrier · 2020-07-13T17:16:19Z

Summary

This PR adds an analyze event gylph to EuiIcon,. The analyze event icon opens up the event analyzer from the alert list page in the Security app.

Analyze event icon in dark and light theme

Analyze event icon near other icons

Design

Checklist

[x] Check against all themes for compatibility in both light and dark modes
[ ] Checked in mobile
[x] Checked in Safari and Firefox
[ ] Props have proper autodocs
[x] Added documentation
~~[ ] Checked Code Sandbox works for the any docs examples~~

Added or updated jest tests
~~[ ] Checked for breaking changes and labeled appropriately~~
~~[ ] Checked for accessibility including keyboard-only and screenreader modes~~
A changelog entry exists and is marked appropriately

kibanamachine · 2020-07-13T17:38:01Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3729/

elizabetdev · 2020-07-14T14:12:04Z

Hi @marrasherrier,

Before @chaos start the review I just noticed a few things. The icons don't look good in dark themes. This is happening because you need to do some cleanup in your SVGs.

Also, the icons should be inside a 16x16 pixel grid. Right now, there are in a 14x16 <svg width="14" height="16" viewBox="0 0 14 16" />

We have a manual that might be helpful:
https://github.com/elastic/eui/blob/master/wiki/creating-icons.md#add-the-icon-to-the-eui-repo

You can also take a look at other similar PRs:

kibanamachine · 2020-07-15T17:54:48Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3729/

marrasherrier · 2020-07-15T18:16:50Z

thank you @miukimiu and @cchaos! updated 👍

cchaos

🎉 Woohoo! Nice one!

Looks like you'll need to update the snapshots again to match your updated icon. yarn run test-unit icon -u

Other than that and the following small comments, this looks great!

CHANGELOG.md

cchaos · 2020-07-15T18:23:01Z

src/components/icon/icon.tsx

@@ -42,6 +42,8 @@ const typeToPathMap = {
  advancedSettingsApp: 'app_advanced_settings',
  aggregate: 'aggregate',
  alert: 'alert',
+  analyzeEvent: 'analyze_event',
+  analyzeEventDisabled: 'analyze_event_disabled',


Don't forget to delete this line as well for the old disabled icon.

kibanamachine · 2020-07-15T18:37:36Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3729/

kibanamachine · 2020-07-15T19:48:40Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3729/

kibanamachine · 2020-07-16T12:53:06Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3729/

kibanamachine · 2020-07-16T13:21:18Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3729/

cchaos

🥇 Looks great!

cchaos · 2020-07-16T14:27:28Z

Go ahead and Squash and merge!

kibanamachine · 2020-07-17T17:45:52Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_3729/

* Break up release.js (elastic#3723) * Switch release.js to use arguments instead of env vars * Switch MFA code back to env var so it doesn't leak in CI logs * Update job definition to use --type arg * Support breaking up release steps with args * Break release up to fetch time-sensitive MFA token right before publish * Strip whitespace from each step Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Chandler Prall <chandler.prall@gmail.com> * Allow prop-setting on the FlexItems within DescribedFormGroup (elastic#3717) * Allow prop-setting on the FlexItems within DescribedFormGroup * Add changelog entry * Honor classes on fieldFlexItem * Update src/components/form/described_form_group/described_form_group.test.tsx Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update snap name Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Re-focus EuiSuperSelect input after making a value change (elastic#3734) * Re-focus EuiSuperSelect input after making a value change * changelog * [EuiStat] Allow customizing the render of the title and description HTML tags (elastic#3693) * Add titleElement and descriptionElement to EuiStat * Updated snapshots * Updated changelog * Fixed issue with screenreader * Updated snapshots * Use screen reader only if title and description is a string * updated snapshots * Merge remote-tracking branch 'upstream/master' into fix/stat * Fixed typo in changelod * removed titleChildren * titlechildren as variable * Update CHANGELOG.md Remove an extra line left over from a merge resolution Co-authored-by: Chandler Prall <chandler.prall@gmail.com> * [EuiTable] Expand item action name to allow a function (elastic#3739) * allow for item -> ReactNode in name * docs * CL * Add ssh keys so new tags can be pushed to Github from Jenkins (elastic#3740) * Add ssh keys so new tags can be pushed to Github * Need a vault token before we can pull secrets * update i18ntokens * 27.1.0 * Updated documentation. * Chore/decouple button content (elastic#3730) * [New] EuiButtonContent For rendering the contents of buttons, icon (loading spinner) and text wrapper for children * Use EuiButtonContent in EuiButtonEmpty * Fixing classNames and disabled states * Create EuiButtonDisplay for internal usage * Fix snaps * ts gymnastics * Added tests for EuiButtonContent * More optimization - Extend EuiButtonContentProps - Content styles are in button_content.scss * Restricted list of `element`s * [Docs] Adding more acccessibility-focused notes and examples (elastic#3714) * making more a11y callouts in docs * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * prettier update Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * [EuiFocusTrap] Use `react-focus-on` (elastic#3631) * WIP: react-focus-on * WIP: fix GuideFullScreen * noIsolation; onClickOutside * euiflyout snapshot updates * euiflyout snapshot updates * euimodal snapshot updates * euidatagrid snapshot updates * euicolorpalettepicker snapshot updates * euisuperselect snapshot updates * euicollapsible snapshot updates * euifocustrap snapshot updates * allow for array snapshots with takeMountedSnapshot * docs improvements * default to noIsolation=true and scrollLock=false * CL * Fixed bug in EuiComboBox always showing a scrollbar (elastic#3744) * Fixed EuiComboBox always showing a scrollbar * Adding the right PR number to CL * Added useEuiI18n hook (elastic#3749) * Added useEuiI18n hook * Updated docs with useEuiI18n hook, added snippets * Add support to fetch-1i8n-strings or useEuiI18n to match EuiI18n extraction * Fix up return types for useEuiI18n * Updated custom eslint i18n rule/package to lint useEuiI18n usages * changelog * Remove something I was testing with and lost where I had placeed it. * [EuiSuperDatePicker] Bypass formatting `null` dates (elastic#3750) * prevent formatting on null value * remove unnecessary cast * account for keyboard nav with null selection * CL * Updated EuiComboBox to allow the options list to open for single selection custom options (elastic#3706) * Fixing includes to return true when object exists in array * changelog * Allowing list to open for single selection custom options * Updated changelog * PR review * Improving example * Improving example * Addind isClearable * Improving examples * Improving explanation text * Adding note * Addressing PR issues * Update src-docs/src/views/combo_box/combo_box_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/combo_box/combo_box_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Snippet Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Add analyze event glyph to EuiIcon (elastic#3729) * adding analyze event security icon * updating analyze_event icon * updating again * Update CHANGELOG.md * Update consuming.md (elastic#3769) * Path has changed and the wiki has not been updated. * Fix zIndex for two popup ups (elastic#3768) Clicking both buttons on https://eui.elastic.co/#/tabular-content/data-grid-styling-and-toolbar demo brings up partially hidden popups because their z-index is too low. Increasing by one seems to do the trick. * [Playground] EuiBadge, EuiNotificationBadge, EuiBetaBadge (elastic#3722) * created playground for badges * removed commented code * used validator for iconType and colour * updated variable name * removed colour validation * removed unnecessary imports * removed default values, fullscreen mode * suggesstions * removed placeholder, added required, some badge props set to string * used actual value of child in text field * added sanitize function * fixed unique-key warning * added validation * updated to identify the change whenthe state changes * suggestions * added onCLick function snippet * removed error popup by react-view * removed lint err * removed commented code Co-authored-by: Josh Mock <joshua.mock@elastic.co> Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Scott Gould <sbg@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Ashik Meerankutty <ashik9591@gmail.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com> Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Elizabet Oliveira <elizabet.oliveira@gmail.com> Co-authored-by: Marra Sherrier <45169477+marrasherrier@users.noreply.github.com> Co-authored-by: Alberto Andújar <josealbertoandujar@gmail.com> Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>

* adding analyze event security icon * updating analyze_event icon * updating again * Update CHANGELOG.md

This reverts commit 5bf2918.

marrasherrier and others added 2 commits July 13, 2020 13:06

adding analyze event security icon

5ed4768

Merge branch 'master' into security-icons

c87d6f7

marrasherrier requested review from cchaos and lindseypoli July 13, 2020 17:54

updating analyze_event icon

d70f8e6

marrasherrier changed the title ~~adding analyze event security icon~~ Add analyze event glyph to EuiIcon Jul 15, 2020

Merge branch 'master' into security-icons

83c42af

cchaos suggested changes Jul 15, 2020

View reviewed changes

marrasherrier and others added 2 commits July 15, 2020 14:49

updating again

a98a5c3

Update CHANGELOG.md

87e7fd3

update

1844dea

Merge branch 'master' into security-icons

238a0cf

marrasherrier requested review from cchaos and removed request for lindseypoli July 16, 2020 12:59

cchaos approved these changes Jul 16, 2020

View reviewed changes

Merge branch 'master' into security-icons

a0494e3

marrasherrier merged commit f9b864a into elastic:master Jul 17, 2020

anishagg17 pushed a commit to anishagg17/eui that referenced this pull request Jul 20, 2020

Add analyze event glyph to EuiIcon (elastic#3729)

5bf2918

* adding analyze event security icon * updating analyze_event icon * updating again * Update CHANGELOG.md

anishagg17 added a commit to anishagg17/eui that referenced this pull request Jul 20, 2020

Revert "Add analyze event glyph to EuiIcon (elastic#3729)"

666b0d0

This reverts commit 5bf2918.

anishagg17 added a commit to anishagg17/eui that referenced this pull request Jul 20, 2020

Revert "Add analyze event glyph to EuiIcon (elastic#3729)"

6794865

This reverts commit 5bf2918.

thompsongl mentioned this pull request Jul 23, 2020

Upgrade EUI to v27.2.0 elastic/kibana#72993

Closed

thompsongl mentioned this pull request Jul 31, 2020

Upgrade EUI to v27.4.0 elastic/kibana#74004

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add analyze event glyph to EuiIcon #3729

Add analyze event glyph to EuiIcon #3729

marrasherrier commented Jul 13, 2020 •

edited

Loading

kibanamachine commented Jul 13, 2020

elizabetdev commented Jul 14, 2020

kibanamachine commented Jul 15, 2020

marrasherrier commented Jul 15, 2020

cchaos left a comment

cchaos Jul 15, 2020

kibanamachine commented Jul 15, 2020

kibanamachine commented Jul 15, 2020

kibanamachine commented Jul 16, 2020

kibanamachine commented Jul 16, 2020

cchaos left a comment

cchaos commented Jul 16, 2020

kibanamachine commented Jul 17, 2020

Add analyze event glyph to EuiIcon #3729

Add analyze event glyph to EuiIcon #3729

Conversation

marrasherrier commented Jul 13, 2020 • edited Loading

Summary

Analyze event icon in dark and light theme

Analyze event icon near other icons

Design

Checklist

kibanamachine commented Jul 13, 2020

elizabetdev commented Jul 14, 2020

kibanamachine commented Jul 15, 2020

marrasherrier commented Jul 15, 2020

cchaos left a comment

Choose a reason for hiding this comment

cchaos Jul 15, 2020

Choose a reason for hiding this comment

kibanamachine commented Jul 15, 2020

kibanamachine commented Jul 15, 2020

kibanamachine commented Jul 16, 2020

kibanamachine commented Jul 16, 2020

cchaos left a comment

Choose a reason for hiding this comment

cchaos commented Jul 16, 2020

kibanamachine commented Jul 17, 2020

marrasherrier commented Jul 13, 2020 •

edited

Loading