Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Fix missing style prop on custom icons #6888

Merged
merged 2 commits into from
Jun 29, 2023
Merged

[EuiIcon] Fix missing style prop on custom icons #6888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0887d4
[EuiIcon] Fix missing `style` prop on custom icons
cee-chen Jun 29, 2023
bf4635b
changelog
cee-chen Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/icon/icon.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ function testIcon(props: PropsOf<typeof EuiIcon>) {
describe('EuiIcon', () => {
test('is rendered', testIcon({ type: 'search', ...requiredProps }));

shouldRenderCustomStyles(<EuiIcon type="customImg" />);
shouldRenderCustomStyles(<EuiIcon type="videoPlayer" />);

describe('props', () => {
Expand Down
1 change: 1 addition & 0 deletions src/components/icon/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ export class EuiIconClass extends PureComponent<
src={icon}
className={classes}
css={cssStyles}
style={style}
tabIndex={tabIndex}
{...(rest as ImgHTMLAttributes<HTMLImageElement>)}
/>
Expand Down
4 changes: 4 additions & 0 deletions upcoming_changelogs/6888.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Bug fixes**

- Fixed `EuiIcon` not correctly passing the `style` prop custom `img` icons