[EuiDataGrid] Fix column actions not working for draggable datagrid inside modals #8135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
datagrid/8119-inside-modal-fix
branch
from
2091fd1 to
6660ae7
Compare
cee-chen
reviewed
Nov 14, 2024
packages/eui/src/components/datagrid/body/header/draggable_columns.tsx
Outdated
Show resolved
Hide resolved
cee-chen
approved these changes
Nov 14, 2024
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Nov 27, 2024
`v97.3.1-borealis.2`⏩`v98.0.0-borealis.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- # `@elastic/eui` ## [`v98.0.0`](https://github.com/elastic/eui/releases/v98.0.0) **Bug fixes** - Fixed an `EuiDataGrid` bug where column actions where not clickable when `EuiDataGrid` with `columnVisibility.canDragAndDropColumns` was used inside a modal ([#8135](elastic/eui#8135)) **Breaking changes** - Removed `EuiFormRow`'s deprecated `columnCompressedSwitch` display prop. Use `columnCompressed` instead ([#8113](elastic/eui#8113)) # `@elastic/eui-theme-borealis` **Bug fixes** - Fixed computed border token mapping (elastic/eui#8170) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
`v97.3.1-borealis.2`⏩`v98.0.0-borealis.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- # `@elastic/eui` ## [`v98.0.0`](https://github.com/elastic/eui/releases/v98.0.0) **Bug fixes** - Fixed an `EuiDataGrid` bug where column actions where not clickable when `EuiDataGrid` with `columnVisibility.canDragAndDropColumns` was used inside a modal ([elastic#8135](elastic/eui#8135)) **Breaking changes** - Removed `EuiFormRow`'s deprecated `columnCompressedSwitch` display prop. Use `columnCompressed` instead ([elastic#8113](elastic/eui#8113)) # `@elastic/eui-theme-borealis` **Bug fixes** - Fixed computed border token mapping (elastic/eui#8170) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8119
This PR fixes an issue for
EuiDataGridwithcolumnVisibility.canDragAndDropColumnsenabled and used insideEuiModalwhere the column actions would not be clickable.This was caused by a custom "blur"/"clickAway" event being fired (added here) because the selector for this condition was selecting the modal focus trap instead of the column action one.
Changes
before
Screen.Recording.2024-11-13.at.14.53.13.mov
after
Screen.Recording.2024-11-13.at.14.53.37.mov
TODO
QA
EuiDataGridwith draggable columns still works as expectedGeneral checklist
Checked in both light and dark modesChecked in mobileChecked for accessibility including keyboard-only and screenreader modesAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesUpdated visual regression testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)