Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Upgrade EUI to v98.2.1-borealis.1 #204783

Open
wants to merge 4 commits into
base: 8.x
Choose a base branch
from
Open

[8.x] Upgrade EUI to v98.2.1-borealis.1 #204783

wants to merge 4 commits into from

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Dec 18, 2024 •
edited
Loading

Important

This PR introduces the Borealis enabled EUI package to 8.x.
The intention is to support new features being developed that need to live in main as well as 8.x.

Important

All 8.x versions should continue to use the current Amsterdam theme. To ensure this even with upcoming changes to the default theme for EUI, we're adding euiThemeAmsterdam on EuiProvider usages manually.

Description

This PR introduces all previous Borealis related PR changes but excludes the specific changes to support @elastic/eui-theme-borealis as only Amsterdam is supported as theme in 8.x.

Previous PRs

v97.3.1⏩v98.2.1-borealis.1

Questions? Please see our Kibana upgrade FAQ.

@elastic/eui

v98.2.1

  • Updated the EUI theme color values to use a full 6 char hex code format (#8244)

v98.2.0

  • Added two new icons: contrast and contrastHigh (#8216)
  • Updated EuiDataGrid content to have a transparent background. (#8220)

Accessibility

  • When the tooltips components (EuiTooltip, EuiIconTip) are used inside components that handle the Escape key (like EuiFlyout or EuiModal), pressing the Escape key will now only close the tooltip and not the entire wrapping component. (#8140)
  • Improved the accessibility of EuiCodeBlocks by (#8195)
    • adding screen reader only labels
    • adding role="dialog" on in fullscreen mode
    • ensuring focus is returned on closing fullscreen mode

Borealis updates

  • [Visual Refresh] Update color token mappings (#8211)
  • [Visual Refresh] Introduce shared popover arrow styles to Borealis (#8212)
  • [Visual Refresh] Add forms.maxWidth token (#8221)
  • [Visual Refresh] Set darker shade for subdued text (#8224)
  • [Visual Refresh] Remove support for accentSecondary badges (#8224)
  • [Visual Refresh] Add severity vis colors (#8247)

@elastic/eui

v98.1.0

  • Updated EuiBetaBadge with a new warning color variant (#8177)

Accessibility

  • Ensures autoFocus on EuiSelectableList triggers initial focus (#8091)
  • Improved the accessibility of EuiSearchBarFilters by: (#8091)
    • adding a more descriptive aria-label to selection filter buttons
    • ensuring the selection listbox is initially focused when opening a selection popover
  • Improved the accessibility experience of tabs (EuiTab, EuiTabs): tab group is a tab stop and tabs can be traversed with arrow keys. (#8116)
  • Updated EuiCodeBlock with a new copyAriaLabel prop, which allows setting a custom screen reader label on the copy button. (#8176)

CSS-in-JS conversions

  • Removed the following global Sass variables: (#8169)
    • $euiButtonMinWidth
    • $euiDatePickerCalendarWidth
  • Removed the following Sass animations: (#8169)
    • euiAnimFadeIn
    • euiGrow
    • focusRingAnimate
    • focusRingAnimateLarge
    • euiButtonActive
  • Removed the following Sass mixins: (#8169)
    • euiFullHeight
    • euiSlightShadowHover
    • datePickerArrow

Borealis updates

@elastic/eui

v98.0.0

Bug fixes

  • Fixed an EuiDataGrid bug where column actions where not clickable when EuiDataGrid with columnVisibility.canDragAndDropColumns was used inside a modal (#8135)

Breaking changes

  • Removed EuiFormRow's deprecated columnCompressedSwitch display prop. Use columnCompressed instead (#8113)

Borealis updates

Bug fixes

@mgadewoll mgadewoll added release_note:skip Skip the PR/issue when compiling release notes EUI EUI Visual Refresh backport:skip This commit does not require backporting labels Dec 18, 2024
@mgadewoll mgadewoll changed the title [8.x] Upgrade EUI to 98.2.1-borealis.1 [8.x] Upgrade EUI to v98.2.1-borealis.1 Dec 18, 2024
@mgadewoll mgadewoll force-pushed the eui/v98.2.1-borealis.1-8.x branch from 20ed9bf to 1f95556 Compare December 19, 2024 09:14
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #11 / security APIs - Session Idle Session Idle cleanup should properly clean up session expired because of idle timeout when providers override global session config

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
controls 364 368 +4
dashboard 688 693 +5
infra 1531 1540 +9
kubernetesSecurity 202 211 +9
maps 1259 1264 +5
ml 2129 2138 +9
visTypeVega 280 289 +9
total +50

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 621.6KB 621.7KB +104.0B
alerting 98.6KB 98.7KB +26.0B
apm 3.5MB 3.5MB +52.0B
canvas 1.1MB 1.1MB +28.0B
cloudDataMigration 6.1KB 6.2KB +26.0B
cloudSecurityPosture 502.9KB 502.9KB +26.0B
controls 460.0KB 494.6KB +34.7KB
core 60.9KB 60.9KB +1.0B
crossClusterReplication 146.5KB 146.5KB +26.0B
dashboard 632.4KB 667.9KB +35.5KB
dataQuality 28.5KB 28.5KB +26.0B
dataUsage 243.0KB 243.0KB +26.0B
dataViewManagement 140.0KB 140.0KB +26.0B
dataVisualizer 614.8KB 614.9KB +130.0B
devTools 8.0KB 8.0KB +26.0B
discover 813.8KB 813.8KB +26.0B
enterpriseSearch 2.6MB 2.6MB +26.0B
entityManagerApp 12.5KB 12.5KB +26.0B
eventAnnotationListing 231.7KB 231.8KB +26.0B
exploratoryView 182.9KB 183.0KB +26.0B
expressionPartitionVis 35.6KB 35.6KB -1.0B
filesManagement 125.5KB 125.5KB +26.0B
fileUpload 951.4KB 951.4KB -1.0B
graph 418.0KB 418.1KB +26.0B
grokdebugger 11.2KB 11.2KB +26.0B
home 152.2KB 152.2KB +26.0B
imageEmbeddable 69.5KB 69.6KB +52.0B
indexLifecycleManagement 166.1KB 166.1KB +26.0B
infra 1.7MB 1.8MB +42.8KB
ingestPipelines 406.7KB 406.7KB +1.0B
inputControlVis 52.3KB 52.3KB +26.0B
inventory 234.1KB 234.1KB +26.0B
investigateApp 484.3KB 484.3KB +26.0B
kibanaOverview 54.9KB 54.9KB +26.0B
kibanaReact 197.1KB 197.1KB +1.0B
kibanaUtils 60.8KB 60.8KB +1.0B
kubernetesSecurity 216.4KB 259.7KB +43.3KB
lens 1.5MB 1.5MB +26.0B
licenseManagement 46.8KB 46.8KB +26.0B
links 53.0KB 53.1KB +52.0B
logstash 33.6KB 33.7KB +26.0B
management 48.5KB 48.6KB +26.0B
maps 3.0MB 3.0MB +35.5KB
metricsDataAccess 99.7KB 99.7KB +26.0B
ml 4.7MB 4.7MB +43.0KB
monitoring 533.6KB 533.6KB +26.0B
observabilityAIAssistantApp 295.1KB 295.1KB +19.0B
observabilityLogsExplorer 147.7KB 147.7KB +26.0B
observabilityOnboarding 283.1KB 283.1KB +26.0B
painlessLab 18.7KB 18.8KB +26.0B
profiling 406.3KB 406.3KB +26.0B
remoteClusters 79.4KB 79.5KB +26.0B
rollup 115.8KB 115.8KB +26.0B
savedObjectsManagement 86.9KB 87.0KB +26.0B
searchAssistant 165.0KB 165.0KB +26.0B
searchHomepage 55.0KB 55.1KB +26.0B
searchIndices 167.7KB 167.7KB +26.0B
searchInferenceEndpoints 98.8KB 98.8KB +26.0B
searchNotebooks 14.2KB 14.2KB +26.0B
searchPlayground 163.2KB 163.2KB +26.0B
searchprofiler 49.0KB 49.1KB +26.0B
security 540.7KB 540.7KB +1.0B
securitySolution 18.5MB 18.5MB +160.0B
serverlessSearch 339.4KB 339.5KB +52.0B
slo 843.1KB 843.3KB +130.0B
snapshotRestore 263.3KB 263.3KB +26.0B
streamsApp 116.4KB 116.5KB +26.0B
synthetics 1.1MB 1.1MB +52.0B
timelines 33.0KB 33.0KB +26.0B
transform 475.5KB 475.5KB +26.0B
triggersActionsUi 1.7MB 1.7MB +286.0B
uptime 468.4KB 468.4KB +26.0B
ux 168.2KB 168.3KB +26.0B
visTypeTimeseries 507.3KB 507.3KB +1.0B
visTypeVega 1.9MB 1.9MB +42.8KB
watcher 166.5KB 166.5KB +26.0B
total +279.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 7.7KB 7.7KB +26.0B
banners 10.7KB 10.7KB +26.0B
cases 159.6KB 159.6KB +26.0B
cloudLinks 30.4KB 30.5KB +26.0B
console 38.6KB 38.6KB +26.0B
core 451.0KB 451.4KB +447.0B
dashboard 51.6KB 51.6KB +26.0B
dashboardEnhanced 18.1KB 18.1KB +26.0B
data 420.0KB 420.1KB +26.0B
dataViewEditor 13.8KB 13.8KB +26.0B
dataViewFieldEditor 27.0KB 27.0KB +26.0B
embeddable 49.0KB 49.0KB +26.0B
expressionError 7.5KB 7.5KB +26.0B
expressionGauge 16.5KB 16.5KB +26.0B
expressionHeatmap 17.4KB 17.4KB +26.0B
expressionImage 6.8KB 6.9KB +26.0B
expressionLegacyMetricVis 12.7KB 12.7KB +26.0B
expressionMetric 8.1KB 8.2KB +26.0B
expressionMetricVis 17.1KB 17.1KB +26.0B
expressionPartitionVis 29.3KB 29.4KB +27.0B
expressionRepeatImage 8.6KB 8.6KB +26.0B
expressionRevealImage 8.6KB 8.6KB +26.0B
expressionShape 23.1KB 23.1KB +26.0B
expressionTagcloud 13.5KB 13.5KB +26.0B
expressionXY 42.2KB 42.2KB +26.0B
fleet 173.2KB 173.2KB +26.0B
globalSearchBar 30.0KB 30.0KB +26.0B
guidedOnboarding 29.8KB 29.8KB +26.0B
indexManagement 46.9KB 46.9KB +26.0B
ingestPipelines 17.7KB 17.7KB +26.0B
inspector 25.1KB 25.2KB +26.0B
interactiveSetup 60.0KB 60.0KB +26.0B
kbnUiSharedDeps-npmDll 5.8MB 5.9MB +63.9KB
kibanaReact 40.0KB 40.0KB +26.0B
kibanaUtils 68.8KB 68.9KB +27.0B
licensing 11.9KB 11.9KB +26.0B
maps 54.5KB 54.5KB +26.0B
mockIdpPlugin 10.9KB 10.9KB +26.0B
newsfeed 13.0KB 13.0KB +26.0B
observability 105.1KB 105.1KB +26.0B
observabilityAIAssistantApp 16.6KB 16.6KB +26.0B
osquery 47.2KB 47.2KB +26.0B
presentationPanel 43.5KB 43.5KB +26.0B
reporting 52.9KB 53.0KB +26.0B
runtimeFields 14.1KB 14.1KB +26.0B
savedObjects 17.8KB 17.9KB +26.0B
savedObjectsTagging 22.8KB 22.9KB +26.0B
security 68.1KB 68.1KB +26.0B
serverless 14.3KB 14.4KB +26.0B
share 58.0KB 58.0KB +26.0B
spaces 34.2KB 34.3KB +26.0B
telemetry 25.1KB 25.1KB +26.0B
uiActions 24.2KB 24.2KB +26.0B
unifiedSearch 38.4KB 38.4KB +26.0B
upgradeAssistant 24.8KB 24.8KB +26.0B
visDefaultEditor 24.2KB 24.2KB +26.0B
visTypeMarkdown 9.9KB 9.9KB +26.0B
visTypeTable 19.4KB 19.4KB +26.0B
visTypeTimelion 13.7KB 13.7KB +26.0B
visTypeTimeseries 20.6KB 20.7KB +26.0B
visTypeVega 36.3KB 36.3KB +26.0B
visTypeVislib 15.3KB 15.3KB +26.0B
visualizations 64.9KB 65.0KB +26.0B
total +65.8KB

History

@mgadewoll mgadewoll marked this pull request as ready for review December 19, 2024 11:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@tkajtoch tkajtoch marked this pull request as draft December 19, 2024 12:40
@tkajtoch tkajtoch assigned tkajtoch and unassigned tkajtoch Dec 19, 2024
@tkajtoch tkajtoch marked this pull request as ready for review December 19, 2024 12:40
@JasonStoltz JasonStoltz requested review from a team December 19, 2024 13:04
@JasonStoltz JasonStoltz requested review from a team, dhurley14, pzl and gergoabraham and removed request for a team December 19, 2024 13:05
fkanout
fkanout approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only (package.json) LGTM

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

consulthys
consulthys approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring
(single color change)

MiriamAparicio
MiriamAparicio approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for obs-ux-infra_services-team LGTM

@Dosant Dosant mentioned this pull request Dec 20, 2024
Open
rylnd
rylnd approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no changes to @elastic/security-detection-engine here, but I checked out this branch to verify that the workflows for our our areas continued to work/look correct on the Amsterdam theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant left review comments

@JasonStoltz JasonStoltz JasonStoltz left review comments

@stratoula stratoula stratoula approved these changes

@Heenawter Heenawter Heenawter approved these changes

@fkanout fkanout fkanout approved these changes

@afharo afharo afharo approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@markov00 markov00 markov00 approved these changes

@jughosta jughosta jughosta approved these changes

@consulthys consulthys consulthys approved these changes

@rylnd rylnd rylnd approved these changes

@viduni94 viduni94 viduni94 approved these changes

@elena-shostak elena-shostak elena-shostak approved these changes

@pzl pzl pzl approved these changes

@mistic mistic mistic approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

@dhurley14 dhurley14 Awaiting requested review from dhurley14 dhurley14 was automatically assigned from elastic/security-detection-engine

@gergoabraham gergoabraham Awaiting requested review from gergoabraham gergoabraham was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI Visual Refresh EUI release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.