[Visual Refresh] Fix euiColorFullShade Sass variable mapping #8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
tkajtoch
pushed a commit
that referenced
this pull request
Nov 27, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 16, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
This PR fixes a wrong Sass variable mapping.
euiColorFullShadein light color mode should be mapped toeuiColorPlainDarkas it's the darkest (legacy) shade. It having been mapped toeuiColorPlainLight(which is white) was a mistake, likely due to copying.QA
There is no actual output of this in EUI. The EUI docs here use the legacy JSON tokens as output.