Make EuiPopover copy the anchor's z-index to the popover content #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add the flyout example in your GIF to this PR? |
nreese
reviewed
Jul 3, 2018
src/components/popover/popover.js
Outdated
| @@ -189,9 +189,15 @@ export class EuiPopover extends Component { | |||
| } | |||
| }); | |||
|
|
|||
| // the popver's z-index must inherit from the button | |||
| // this keeps a button's popver under a flyover that would covert the button | |||
There was a problem hiding this comment.
spelling "covert" => "cover"
There was a problem hiding this comment.
good catch, thanks!
|
@nreese I've pushed an update adding a popover to the complicated flyout example |
cchaos
reviewed
Jul 3, 2018
| @@ -156,6 +162,13 @@ export class FlyoutComplicated extends Component { | |||
| <EuiSpacer size="s" /> | |||
| <EuiText color="subdued"> | |||
| <p>Put navigation items in the header, and cross tab actions in a footer.</p> | |||
| <EuiPopover | |||
There was a problem hiding this comment.
@chandlerprall Can you actually move this popover to the flyout body and outside of any EuiText elements.
There was a problem hiding this comment.
Sorry, can you move it out of EuiFlyoutHeader and into <EuiFlyoutBody> below the EuiCodeBlock (line 181)? I want to be sure that when consumers copy-paste this, they're not overusing popovers in the headers.
nreese
approved these changes
Jul 3, 2018
|
@cchaos popover has been moved into the flyout body |
|
TY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #965
This sets the content's z-index from the anchor element's z-index. The value must be calculated/copied instead of hard-coding in css as e.g. the popover may need to show behind a flyout from one button but be in front if it relates to content in the flyout.
without setting z-index
with z-index
adding
@cchaos sanity check, testing
@nreese / @cjcenizal to make sure the code change & comments are understandable