-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename config to policy and dataset to datastream #280
Rename config to policy and dataset to datastream #280
Conversation
Hi @mtojek, thanks for helping me get my registry running with this branch. I found that the package info endpoint doesn't contain Are you seeing the same? |
@jen-huang I might be off here but is the registry you are running built with this PR's changes in it: elastic/package-registry#641? |
@jen-huang , confirmed (I see the same results). It looks that you need to checkout the PR @ycombinator posted above (elastic/package-registry#641), then:
In testing/environments, you need to update the reference to the Docker image:
and finally:
|
Thanks both!! I am seeing the correct package info now. Will continue with my testing. |
Another issue found: I think elastic/package-registry#641 is missing Example from system package info: "data_streams": [
{
"type": "logs",
- "name": "system.auth",
+ "dataset": "system.auth",
"title": "System auth logs",
"release": "experimental",
"ingest_pipeline": "default",
...
},
...
] |
I was able to monkey patch my local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review actual code but tested this with elastic/kibana#78699 and it works well 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over the changes and they look good 👍
* Rename config_templates to policy_templates * Setup dependencies * Rename dataset folder to data_stream * Bump up versions * Rename dataset to dataStream in source * Rename config template to policy template * Hack dependency on mtojek fork * Fix: docs * Fix: docs * Fix: mage check * Missed renamings * Update dep on package-registry * Fix: mage check * Fix: remove hacked dependencies * Switch back to master * Bump up version on Linux package
What does this PR do?
Checklist
Author's Checklist
How to test this PR locally
package-registry should be exposed under http://localhost:8080 .
Related issues
Screenshots