Rename config template to policy template and dataset to datastream #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
6 tasks
jen-huang
reviewed
Sep 29, 2020
util/data_stream.go
Outdated
| type Dataset struct { | ||
| // Name and type of the dataset. This is linked to dataset.name and dataset.type fields. | ||
| type DataStream struct { | ||
| // Name and type of the dataStream. This is linked to dataStream.name and dataStream.type fields. | ||
| Type string `config:"type" json:"type" validate:"required"` | ||
| Name string `config:"name" json:"name,omitempty" yaml:"name,omitempty"` |
There was a problem hiding this comment.
name should be dataset following https://github.com/elastic/package-spec/pull/24/files#diff-13d2900dcce8e312a06c834b665816a1R71
There was a problem hiding this comment.
Thanks for finding it! I'm looking into this.
|
Nit: s/dataset/data stream/ in: |
Thanks, fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames config templates to policy templates and datasets to datastreams.
I regenerated golden files.