[APM] Quote trace id to ensure a word is searched (#69500) (#69504) (#…

…70977) * [APM] Quote trace id to ensure a word is searched (#69500) Signed-off-by: Mathis Raguin <mathis@cri.epita.fr> * [APM] Fix TransactionActionMenu tests (one test was not updated) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Mathis <Sayrus@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elastic · Jul 7, 2020 · 0c064da · 0c064da
1 parent 9f3598d
commit 0c064da
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/...pm/public/components/shared/TransactionActionMenu/__test__/TransactionActionMenu.test.tsx b/...pm/public/components/shared/TransactionActionMenu/__test__/TransactionActionMenu.test.tsx
@@ -94,7 +94,7 @@ describe('TransactionActionMenu component', () => {
 
     expect(mock.core.application.navigateToApp).toHaveBeenCalledWith('logs', {
       path:
-        'link-to/logs?time=1545092070952&filter=trace.id:%228b60bd32ecc6e1506735a8b6cfcf175c%22%20OR%208b60bd32ecc6e1506735a8b6cfcf175c',
+        'link-to/logs?time=1545092070952&filter=trace.id:%228b60bd32ecc6e1506735a8b6cfcf175c%22%20OR%20%228b60bd32ecc6e1506735a8b6cfcf175c%22',
     });
   });
 

diff --git a/x-pack/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts b/x-pack/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts
@@ -42,7 +42,7 @@ describe('Transaction action menu', () => {
               key: 'traceLogs',
               label: 'Trace logs',
               href:
-                'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20123',
+                'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20%22123%22',
               condition: true,
             },
           ],
@@ -113,7 +113,7 @@ describe('Transaction action menu', () => {
               key: 'traceLogs',
               label: 'Trace logs',
               href:
-                'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20123',
+                'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20%22123%22',
               condition: true,
             },
           ],
@@ -183,7 +183,7 @@ describe('Transaction action menu', () => {
               key: 'traceLogs',
               label: 'Trace logs',
               href:
-                'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20123',
+                'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20%22123%22',
               condition: true,
             },
           ],

diff --git a/x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections.ts b/x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections.ts
@@ -180,7 +180,7 @@ export const getSections = ({
         path: `/link-to/logs`,
         query: {
           time,
-          filter: `trace.id:"${transaction.trace.id}" OR ${transaction.trace.id}`,
+          filter: `trace.id:"${transaction.trace.id}" OR "${transaction.trace.id}"`,
         },
       }),
       condition: true,
-Original file line number
+Diff line change
@@ Expand Up / @@ -94,7 +94,7 @@ describe('TransactionActionMenu component', () => { @@
         expect(mock.core.application.navigateToApp).toHaveBeenCalledWith('logs', {
           path:
-            'link-to/logs?time=1545092070952&filter=trace.id:%228b60bd32ecc6e1506735a8b6cfcf175c%22%20OR%208b60bd32ecc6e1506735a8b6cfcf175c',
+            'link-to/logs?time=1545092070952&filter=trace.id:%228b60bd32ecc6e1506735a8b6cfcf175c%22%20OR%20%228b60bd32ecc6e1506735a8b6cfcf175c%22',
         });
       });
@@ Expand Down @@