[APM] Quote trace id to ensure a word is searched (#69500) #69504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
kibanamachine
added
💝community
and removed
Team:APM
|
💚 CLA has been signed |
|
Pinging @elastic/apm-ui (Team:apm) |
Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>
Sayrus
force-pushed
the
apm-jump-to-trace-action-filter
branch
from
d5d76fa to
1257729
Compare
sorenlouv
approved these changes
Jun 18, 2020
|
@elasticmachine merge upstream |
|
retest |
|
Seems like I forgot a test, this is fixed now. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
retest |
1 similar comment
|
retest |
|
@elasticmachine merge upstream |
|
retest |
|
@elasticmachine merge upstream |
|
retest |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
sorenlouv
pushed a commit
to sorenlouv/kibana
that referenced
this pull request
Jul 7, 2020
…astic#69504) * [APM] Quote trace id to ensure a word is searched (elastic#69500) Signed-off-by: Mathis Raguin <mathis@cri.epita.fr> * [APM] Fix TransactionActionMenu tests (one test was not updated) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sorenlouv
added a commit
that referenced
this pull request
Jul 7, 2020
…70977) * [APM] Quote trace id to ensure a word is searched (#69500) Signed-off-by: Mathis Raguin <mathis@cri.epita.fr> * [APM] Fix TransactionActionMenu tests (one test was not updated) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Mathis <Sayrus@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
Thanks for the contribution @Sayrus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69500
This PR quotes the trace ID when using the Jump to trace logs feature in the APM.
This solves #69500. I don't think this is a breaking change in any way but I'm not familiar enough with Kibana.
Checklist
For maintainers