Skip to content

Commit

Permalink
Rename all vis-editors and datavis to visualizations (#144589)
Browse files Browse the repository at this point in the history
* rename all the vis-editors

* rename datavis to visualizations
  • Loading branch information
flash1293 authored Nov 5, 2022
1 parent 7c822c0 commit 15c12bd
Show file tree
Hide file tree
Showing 39 changed files with 46 additions and 46 deletions.
10 changes: 5 additions & 5 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -885,12 +885,12 @@ packages/kbn-babel-preset @elastic/kibana-operations
packages/kbn-bazel-packages @elastic/kibana-operations
packages/kbn-bazel-runner @elastic/kibana-operations
packages/kbn-cases-components @elastic/response-ops
packages/kbn-chart-icons @elastic/kibana-vis-editors
packages/kbn-chart-icons @elastic/kibana-visualizations
packages/kbn-ci-stats-core @elastic/kibana-operations
packages/kbn-ci-stats-performance-metrics @elastic/kibana-operations
packages/kbn-ci-stats-reporter @elastic/kibana-operations
packages/kbn-cli-dev-mode @elastic/kibana-operations
packages/kbn-coloring @elastic/kibana-vis-editors
packages/kbn-coloring @elastic/kibana-visualizations
packages/kbn-config @elastic/kibana-core
packages/kbn-config-mocks @elastic/kibana-core
packages/kbn-config-schema @elastic/kibana-core
Expand Down Expand Up @@ -933,7 +933,7 @@ packages/kbn-io-ts-utils @elastic/apm-ui
packages/kbn-jest-serializers @elastic/kibana-operations
packages/kbn-journeys @elastic/kibana-operations
packages/kbn-kibana-manifest-schema @elastic/kibana-operations
packages/kbn-language-documentation-popover @elastic/kibana-vis-editors
packages/kbn-language-documentation-popover @elastic/kibana-visualizations
packages/kbn-logging @elastic/kibana-core
packages/kbn-logging-mocks @elastic/kibana-core
packages/kbn-managed-vscode-config @elastic/kibana-operations
Expand Down Expand Up @@ -982,8 +982,8 @@ packages/kbn-telemetry-tools @elastic/kibana-core
packages/kbn-test @elastic/kibana-operations
packages/kbn-test-jest-helpers @elastic/kibana-operations
packages/kbn-test-subj-selector @elastic/kibana-operations
packages/kbn-timelion-grammar @elastic/kibana-vis-editors
packages/kbn-tinymath @elastic/kibana-vis-editors
packages/kbn-timelion-grammar @elastic/kibana-visualizations
packages/kbn-tinymath @elastic/kibana-visualizations
packages/kbn-tooling-log @elastic/kibana-operations
packages/kbn-type-summarizer @elastic/kibana-operations
packages/kbn-type-summarizer-cli @elastic/kibana-operations
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/key_concepts/building_blocks.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ The Dashboard Embeddable is one of the highest-level UI components you can add t

Check out the Lens Embeddable if you wish to show users visualizations based on Elasticsearch data without worrying about query building and chart rendering. It's built on top of the <DocLink id="kibBuildingBlocks" section="expressions" text="Expression language" />, and integrates with <DocLink id="kibBuildingBlocks" section="index-patterns" text="Index Patterns" /> and <DocLink id="kibBuildingBlocks" section="ui-actions--triggers" text="UI Actions" />. Using the same configuration, it's also possible to link to a prefilled Lens editor, allowing the user to drill deeper and explore their data.

**Github labels**: `Team:VisEditors`, `Feature:Lens`
**Github labels**: `Team:Visualizations`, `Feature:Lens`

### Map Embeddable

Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-chart-icons/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "shared-common",
"id": "@kbn/chart-icons",
"owner": "@elastic/kibana-vis-editors",
"owner": "@elastic/kibana-visualizations",
"runtimeDeps": [],
"typeDeps": []
}
2 changes: 1 addition & 1 deletion packages/kbn-coloring/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "shared-common",
"id": "@kbn/coloring",
"owner": "@elastic/kibana-vis-editors",
"owner": "@elastic/kibana-visualizations",
"runtimeDeps": [],
"typeDeps": []
}
2 changes: 1 addition & 1 deletion packages/kbn-language-documentation-popover/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "shared-common",
"id": "@kbn/language-documentation-popover",
"owner": "@elastic/kibana-vis-editors",
"owner": "@elastic/kibana-visualizations",
"runtimeDeps": [],
"typeDeps": []
}
2 changes: 1 addition & 1 deletion packages/kbn-timelion-grammar/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "shared-common",
"id": "@kbn/timelion-grammar",
"owner": "@elastic/kibana-vis-editors",
"owner": "@elastic/kibana-visualizations",
"runtimeDeps": [],
"typeDeps": []
}
2 changes: 1 addition & 1 deletion packages/kbn-tinymath/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "shared-common",
"id": "@kbn/tinymath",
"owner": "@elastic/kibana-vis-editors",
"owner": "@elastic/kibana-visualizations",
"runtimeDeps": [],
"typeDeps": []
}
8 changes: 4 additions & 4 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
{
"groupName": "@elastic/charts",
"matchPackageNames": ["@elastic/charts"],
"reviewers": ["team:datavis", "markov00", "nickofthyme"],
"reviewers": ["team:visualizations", "markov00", "nickofthyme"],
"matchBaseBranches": ["main"],
"labels": ["release_note:skip", "backport:skip", "Team:DataVis"],
"labels": ["release_note:skip", "backport:skip", "Team:Visualizations"],
"draftPR": true,
"enabled": true,
"assignAutomerge": true,
Expand Down Expand Up @@ -97,9 +97,9 @@
{
"groupName": "vega related modules",
"matchPackageNames": ["vega", "vega-lite", "vega-schema-url-parser", "vega-tooltip"],
"reviewers": ["team:kibana-vis-editors"],
"reviewers": ["team:kibana-visualizations"],
"matchBaseBranches": ["main"],
"labels": ["Feature:Vega", "Team:VisEditors"],
"labels": ["Feature:Vega", "Team:Visualizations"],
"enabled": true
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/chart_expressions/expression_gauge/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"kibanaVersion": "kibana",
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Expression Gauge plugin adds a `gauge` renderer and function to the expression plugin. The renderer will display the `gauge` chart.",
"server": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"kibanaVersion": "kibana",
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Expression Heatmap plugin adds a `heatmap` renderer and function to the expression plugin. The renderer will display the `heatmap` chart.",
"server": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"kibanaVersion": "kibana",
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `legacy metric` chart.",
"server": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"kibanaVersion": "kibana",
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `metric` chart.",
"server": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"kibanaVersion": "kibana",
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Expression Partition Visualization plugin adds a `partitionVis` renderer and `pieVis`, `mosaicVis`, `treemapVis`, `waffleVis` functions to the expression plugin. The renderer will display the `pie`, `waffle`, `treemap` and `mosaic` charts.",
"server": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"optionalPlugins": ["usageCollection"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Expression Tagcloud plugin adds a `tagcloud` renderer and function to the expression plugin. The renderer will display the `Wordcloud` chart."
}
2 changes: 1 addition & 1 deletion src/plugins/chart_expressions/expression_xy/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"kibanaVersion": "kibana",
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Expression XY plugin adds a `xy` renderer and function to the expression plugin. The renderer will display the `xy` chart.",
"server": true,
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/charts/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"requiredPlugins": ["expressions"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
2 changes: 1 addition & 1 deletion src/plugins/event_annotation/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
2 changes: 1 addition & 1 deletion src/plugins/management/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"requiredBundles": ["kibanaReact", "kibanaUtils"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
2 changes: 1 addition & 1 deletion src/plugins/url_forwarding/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"ui": true,
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
2 changes: 1 addition & 1 deletion src/plugins/vis_default_editor/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "The default editor used in most aggregation-based visualizations."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/gauge/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Contains the gauge chart implementation using the elastic-charts library. The goal is to eventually deprecate the old implementation and keep only this. Until then, the library used is defined by the Legacy charts library advanced setting."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/heatmap/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Contains the heatmap implementation using the elastic-charts library. The goal is to eventually deprecate the old implementation and keep only this. Until then, the library used is defined by the Legacy heatmap charts library advanced setting."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/metric/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Registers the Metric aggregation-based visualization."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/pie/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Contains the pie chart implementation using the elastic-charts library. The goal is to eventually deprecate the old implementation and keep only this. Until then, the library used is defined by the Legacy charts library advanced setting."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/table/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Registers the datatable aggregation-based visualization."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/tagcloud/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"requiredBundles": ["kibanaReact", "visDefaultEditor"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Registers the tagcloud visualization. It is based on elastic-charts wordcloud."

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/vis_types/timelion/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"optionalPlugins": ["usageCollection"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Registers the timelion visualization. Also contains the backend for both timelion app and timelion visualization."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/timeseries/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"requiredBundles": ["unifiedSearch", "kibanaUtils", "kibanaReact", "fieldFormats"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Registers the TSVB visualization. TSVB has its one editor, works with index patterns and index strings and contains 6 types of charts: timeseries, topN, table. markdown, metric and gauge."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/vega/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Registers the vega visualization. Is the elastic version of vega and vega-lite libraries."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/vislib/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"requiredBundles": ["kibanaUtils", "visTypePie", "visTypeHeatmap", "visTypeGauge", "kibanaReact"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Contains the vislib visualizations. These are the classical area/line/bar, pie, gauge/goal and heatmap charts. We want to replace them with elastic-charts."
}
2 changes: 1 addition & 1 deletion src/plugins/vis_types/xy/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"extraPublicDirs": ["common/index"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Contains the new xy-axis chart using the elastic-charts library, which will eventually replace the vislib xy-axis charts including bar, area, and line."
}
2 changes: 1 addition & 1 deletion src/plugins/visualizations/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"extraPublicDirs": ["common/constants", "common/utils", "common/expression_functions", "common/convert_to_lens"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Contains the shared architecture among all the legacy visualizations, e.g. the visualization type registry or the visualization embeddable."
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "kbnTpCustomVisualizations",
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"version": "0.0.1",
"kibanaVersion": "kibana",
Expand Down
2 changes: 1 addition & 1 deletion x-pack/examples/embedded_lens_example/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"requiredBundles": [],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
2 changes: 1 addition & 1 deletion x-pack/examples/testing_embedded_lens/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"requiredBundles": [],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
2 changes: 1 addition & 1 deletion x-pack/examples/third_party_vis_lens_example/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
}
}
2 changes: 1 addition & 1 deletion x-pack/plugins/lens/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
"githubTeam": "kibana-visualizations"
},
"description": "Visualization editor allowing to quickly and easily configure compelling visualizations to use on dashboards and canvas workpads. Exposes components to embed visualizations and link into the Lens editor from within other apps in Kibana."
}
2 changes: 1 addition & 1 deletion x-pack/plugins/lens/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ When adding visualizations to a solution page, there are multiple ways to approa
* Limited data processing options - if the Lens UI doesn't support it, it can't be used
* Limited visualization options - if Lens can't do it, it's not possible
* #### **Using custom data fetching and rendering**
In case the disadvantages of using the Lens embeddable heavily affect your use case, it sometimes makes sense to roll your own data fetching and rendering by using the underlying APIs of search service and `elastic-charts` directly. This allows a high degree of flexibility when it comes to data processing, efficiently querying data for multiple charts in a single query and adjusting small details in how charts are rendered. However, do not choose these option lightly as maintenance as well as initial development effort will most likely be much higher than by using the Lens embeddable directly. In this case, almost always an "Open in Lens" button can still be offered to the user to drill down and further explore the data by generating a Lens configuration which is similar to the displayed visualization given the possibilities of Lens. Keep in mind that for the "Open in Lens" flow, the most important property isn't perfect fidelity of the chart but retaining the mental context of the user when switching so they don't have to start over. It's also possible to mix this approach with Lens embeddables on a single page. **Note**: In this situation, please let the VisEditors team know what features you are missing / why you chose not to use Lens.
In case the disadvantages of using the Lens embeddable heavily affect your use case, it sometimes makes sense to roll your own data fetching and rendering by using the underlying APIs of search service and `elastic-charts` directly. This allows a high degree of flexibility when it comes to data processing, efficiently querying data for multiple charts in a single query and adjusting small details in how charts are rendered. However, do not choose these option lightly as maintenance as well as initial development effort will most likely be much higher than by using the Lens embeddable directly. In this case, almost always an "Open in Lens" button can still be offered to the user to drill down and further explore the data by generating a Lens configuration which is similar to the displayed visualization given the possibilities of Lens. Keep in mind that for the "Open in Lens" flow, the most important property isn't perfect fidelity of the chart but retaining the mental context of the user when switching so they don't have to start over. It's also possible to mix this approach with Lens embeddables on a single page. **Note**: In this situation, please let the Visualizations team know what features you are missing / why you chose not to use Lens.

Pros:
* Full flexibility in data fetching optimization and chart rendering
Expand Down

0 comments on commit 15c12bd

Please sign in to comment.