Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all vis-editors and datavis to visualizations #144589

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Rename all vis-editors and datavis to visualizations #144589

merged 2 commits into from
Nov 5, 2022

Conversation

flash1293
Copy link
Contributor

This PR fixes the remaining places where vis-editors and datavis needs to be renamed to visualizations due to the reorg.

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 4, 2022
@flash1293 flash1293 requested review from a team as code owners November 4, 2022 09:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

stratoula
stratoula approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

markov00
markov00 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 enabled auto-merge (squash) November 4, 2022 11:30
alisonelizabeth
alisonelizabeth approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment Management changes LGTM

@flash1293 flash1293 merged commit 15c12bd into elastic:main Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@stratoula stratoula stratoula approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@flash1293 @elasticmachine @kibana-ci @markov00 @alisonelizabeth @stratoula @nickofthyme @kibanamachine