Skip to content

Commit

Permalink
[Alerting UI] Updating 'Add new' wording (#80509) (#80877)
Browse files Browse the repository at this point in the history
* Updating 'Add new' wording

* PR fixes

* i18n_check fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
ymao1 and kibanamachine authored Oct 16, 2020
1 parent bf90405 commit 54b1482
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 7 deletions.
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -18025,7 +18025,6 @@
"xpack.triggersActionsUI.sections.alertsList.unableToLoadActionTypesMessage": "アクションタイプを読み込めません",
"xpack.triggersActionsUI.sections.alertsList.unableToLoadAlertsMessage": "アラートを読み込めません",
"xpack.triggersActionsUI.sections.alertsList.unableToLoadAlertTypesMessage": "アラートタイプを読み込めません",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addBccButton": "{titleBcc}",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addCcButton": "Cc を追加",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.fromTextFieldLabel": "送信元",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.hostTextFieldLabel": "ホスト",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -18036,7 +18036,6 @@
"xpack.triggersActionsUI.sections.alertsList.unableToLoadActionTypesMessage": "无法加载操作类型",
"xpack.triggersActionsUI.sections.alertsList.unableToLoadAlertsMessage": "无法加载告警",
"xpack.triggersActionsUI.sections.alertsList.unableToLoadAlertTypesMessage": "无法加载告警类型",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addBccButton": "{titleBcc}",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addCcButton": "添加抄送收件人",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.fromTextFieldLabel": "发送者",
"xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.hostTextFieldLabel": "主机",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,16 @@ export const EmailParamsFields = ({
{!addCC ? (
<EuiButtonEmpty size="xs" onClick={() => setAddCC(true)}>
<FormattedMessage
defaultMessage="Add Cc"
defaultMessage="Cc"
id="xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addCcButton"
/>
</EuiButtonEmpty>
) : null}
{!addBCC ? (
<EuiButtonEmpty size="xs" onClick={() => setAddBCC(true)}>
<FormattedMessage
defaultMessage="{titleBcc}"
defaultMessage="Bcc"
id="xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addBccButton"
values={{ titleBcc: !addCC ? '/ Bcc' : 'Add Bcc' }}
/>
</EuiButtonEmpty>
) : null}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ describe('action_form', () => {
`);
});

it('does not render "Add new" button for preconfigured only action type', async () => {
it('does not render "Add connector" button for preconfigured only action type', async () => {
await setup();
const actionOption = wrapper.find('[data-test-subj="preconfigured-ActionTypeSelectOption"]');
actionOption.first().simulate('click');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export const ActionForm = ({
}}
>
<FormattedMessage
defaultMessage="Add new"
defaultMessage="Add connector"
id="xpack.triggersActionsUI.sections.alertForm.addNewConnectorEmptyButton"
/>
</EuiButtonEmpty>
Expand Down

0 comments on commit 54b1482

Please sign in to comment.