Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting UI] Updating 'Add new' wording #80509

Merged
merged 4 commits into from
Oct 16, 2020
Merged

[Alerting UI] Updating 'Add new' wording #80509

merged 4 commits into from
Oct 16, 2020

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Oct 14, 2020

Resolves #79532

Summary

Updating wording on action form from 'Add new' to 'Add new connector' to provide specificity.

Screen Shot 2020-10-14 at 9 19 30 AM

Checklist

Delete any items that are not applicable to this PR.

@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0 labels Oct 14, 2020
@ymao1 ymao1 marked this pull request as ready for review October 14, 2020 15:41
@ymao1 ymao1 requested a review from a team as a code owner October 14, 2020 15:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

mikecote
mikecote approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but I would double check with @gchaps if the wording should be Add new connector or Add connector.

@ymao1 ymao1 requested a review from gchaps October 14, 2020 17:15
@ymao1 ymao1 self-assigned this Oct 14, 2020
gchaps
gchaps reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it's not in this PR, but I suggest changing "Add CC / Bcc" to "CC Bcc". This format is common in email compose windows.

...lugins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx Outdated Show resolved Hide resolved
...s/triggers_actions_ui/public/application/sections/action_connector_form/action_form.test.tsx Outdated Show resolved Hide resolved
@ymao1
Copy link
Contributor Author

ymao1 commented Oct 15, 2020

@gchaps Updated!
Screen Shot 2020-10-14 at 9 17 22 PM

gchaps
gchaps approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Oct 15, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
triggersActionsUi 1.5MB 1.5MB -48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris
gmmorris approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 merged commit db4184f into elastic:master Oct 16, 2020
ymao1 added a commit to ymao1/kibana that referenced this pull request Oct 16, 2020
@ymao1 @kibanamachine
[Alerting UI] Updating 'Add new' wording (elastic#80509)
35df8e6 
* Updating 'Add new' wording

* PR fixes

* i18n_check fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ymao1 ymao1 mentioned this pull request Oct 16, 2020
Merged
ymao1 added a commit that referenced this pull request Oct 16, 2020
@ymao1 @kibanamachine
[Alerting UI] Updating 'Add new' wording (#80509) (#80877)
54b1482 
* Updating 'Add new' wording

* PR fixes

* i18n_check fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
@gmmorris
Merge branch 'master' into task-manager/refactor-oversized-class
c30d71b 
* master: (43 commits)
  [ML] Transforms: Fix tab ids for expanded row. (elastic#80666)
  server logs config paths to use for runner (elastic#52980)
  Fix audit logger logging to console even when disabled (elastic#80928)
  skip flaky suite (elastic#80929)
  Added Enterprise Search config to kibana-docker (elastic#80872)
  skip flaky suite (elastic#80914)
  [keystore_cli] parse values as JSON before adding to keystore (elastic#80848)
  [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742)
  ECS audit logging (elastic#74640)
  [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215)
  [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854)
  Move renderHeaderActions back into mount useEffect + update tests (elastic#80861)
  [Reporting] Document Network Policy configuration (elastic#80431)
  [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782)
  Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757)
  [Actions] Back Button on Add Connector Flyout (elastic#80160)
  removing `kibana_datatable` in favor of `datatable`  (elastic#80548)
  [Alerting UI] Updating 'Add new' wording (elastic#80509)
  [Docs] Document Encrypted Saved Objects functionality. (elastic#80183)
  [Discover] fix auto-refresh (elastic#80635)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
@gmmorris
Merge branch 'master' into task-manager/health
12e52e6 
* master: (23 commits)
  [ML] Transforms: Fix tab ids for expanded row. (elastic#80666)
  server logs config paths to use for runner (elastic#52980)
  Fix audit logger logging to console even when disabled (elastic#80928)
  skip flaky suite (elastic#80929)
  Added Enterprise Search config to kibana-docker (elastic#80872)
  skip flaky suite (elastic#80914)
  [keystore_cli] parse values as JSON before adding to keystore (elastic#80848)
  [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742)
  ECS audit logging (elastic#74640)
  [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215)
  [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854)
  Move renderHeaderActions back into mount useEffect + update tests (elastic#80861)
  [Reporting] Document Network Policy configuration (elastic#80431)
  [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782)
  Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757)
  [Actions] Back Button on Add Connector Flyout (elastic#80160)
  removing `kibana_datatable` in favor of `datatable`  (elastic#80548)
  [Alerting UI] Updating 'Add new' wording (elastic#80509)
  [Docs] Document Encrypted Saved Objects functionality. (elastic#80183)
  [Discover] fix auto-refresh (elastic#80635)
  ...
@ymao1 ymao1 deleted the alerting/add-new branch February 4, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@mikecote mikecote mikecote approved these changes

@gmmorris gmmorris gmmorris approved these changes

Assignees

@ymao1 ymao1

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "Add new" specific to the object the user is adding
6 participants
@ymao1 @elasticmachine @kibanamachine @gmmorris @mikecote @gchaps