Skip to content

Commit

Permalink
[Roles] Fix wording for updating roles toast to match button text (#1…
Browse files Browse the repository at this point in the history
…94427)

Closes #194406

## Summary

Fix wording for Roles update toast to match button when updating an
existing role.

### Screenshots

<img width="746" alt="image"
src="https://github.com/user-attachments/assets/674a57f3-5a5a-445a-9266-8b55526aef72">


### Release notes
Changes wording for toast message when updating an existing role
successfully. The toast now matches the button to say `Updated role`

---------

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
  • Loading branch information
3 people authored Oct 3, 2024
1 parent 9bc761a commit 5ea1ab0
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -718,12 +718,21 @@ export const EditRolePage: FunctionComponent<Props> = ({
),
});
} else {
notifications.toasts.addSuccess(
i18n.translate(
'xpack.security.management.editRole.roleSuccessfullySavedNotificationMessage',
{ defaultMessage: 'Saved role' }
)
);
if (isEditingExistingRole) {
notifications.toasts.addSuccess(
i18n.translate(
'xpack.security.management.editRole.roleSuccessfullyUpdatedNotificationMessage',
{ defaultMessage: 'Updated role' }
)
);
} else {
notifications.toasts.addSuccess(
i18n.translate(
'xpack.security.management.editRole.roleSuccessfullyCreatedNotificationMessage',
{ defaultMessage: 'Created role' }
)
);
}
}

backToRoleList();
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -34710,7 +34710,6 @@
"xpack.security.management.editRole.roleNameFormRowHelpText": "Un nom de rôle ne peut pas être modifié après sa création.",
"xpack.security.management.editRole.roleNameFormRowTitle": "Nom de rôle",
"xpack.security.management.editRole.roleSuccessfullyDeletedNotificationMessage": "Rôle supprimé",
"xpack.security.management.editRole.roleSuccessfullySavedNotificationMessage": "Rôle enregistré",
"xpack.security.management.editRole.setPrivilegesToKibanaSpacesDescription": "Définissez les privilèges sur vos données Elasticsearch et contrôlez l'accès à vos espaces \"Projet\".",
"xpack.security.management.editRole.simplePrivilegeForm.allPrivilegeDropdown": "Tous",
"xpack.security.management.editRole.simplePrivilegeForm.allPrivilegeDropdownDescription": "Accorde un accès complet à la totalité de Kibana",
Expand Down Expand Up @@ -47684,4 +47683,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "Ce champ est requis.",
"xpack.watcher.watcherDescription": "Détectez les modifications survenant dans vos données en créant, gérant et monitorant des alertes."
}
}
}
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -34454,7 +34454,6 @@
"xpack.security.management.editRole.roleNameFormRowHelpText": "ロール名は作成後変更できません。",
"xpack.security.management.editRole.roleNameFormRowTitle": "ロール名",
"xpack.security.management.editRole.roleSuccessfullyDeletedNotificationMessage": "ロールを削除しました",
"xpack.security.management.editRole.roleSuccessfullySavedNotificationMessage": "ロールを保存しました",
"xpack.security.management.editRole.setPrivilegesToKibanaSpacesDescription": "Elasticsearchデータの権限を設定し、プロジェクトスペースへのアクセスを管理します。",
"xpack.security.management.editRole.simplePrivilegeForm.allPrivilegeDropdown": "すべて",
"xpack.security.management.editRole.simplePrivilegeForm.allPrivilegeDropdownDescription": "Kibana 全体への完全アクセスを許可します",
Expand Down Expand Up @@ -47421,4 +47420,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。",
"xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
}
}
}
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -34498,7 +34498,6 @@
"xpack.security.management.editRole.roleNameFormRowHelpText": "创建角色名称后无法更改。",
"xpack.security.management.editRole.roleNameFormRowTitle": "角色名称",
"xpack.security.management.editRole.roleSuccessfullyDeletedNotificationMessage": "已删除角色",
"xpack.security.management.editRole.roleSuccessfullySavedNotificationMessage": "保存的角色",
"xpack.security.management.editRole.setPrivilegesToKibanaSpacesDescription": "设置 Elasticsearch 数据的权限并控制对项目空间的访问权限。",
"xpack.security.management.editRole.simplePrivilegeForm.allPrivilegeDropdown": "全部",
"xpack.security.management.editRole.simplePrivilegeForm.allPrivilegeDropdownDescription": "授予对 Kibana 全部功能的完全权限",
Expand Down Expand Up @@ -47475,4 +47474,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "此字段必填。",
"xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。"
}
}
}

0 comments on commit 5ea1ab0

Please sign in to comment.