[Roles] Fix wording for updating roles toast to match button text #194427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiddharthMantri
added
release_note:enhancement
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
jeramysoucy
requested changes
Oct 1, 2024
| notifications.toasts.addSuccess( | ||
| i18n.translate( | ||
| 'xpack.security.management.editRole.roleSuccessfullySavedNotificationMessage', | ||
| { defaultMessage: 'Saved role' } |
There was a problem hiding this comment.
Nit: the button in the create render of the edit role page reads "Create role". Should we also update the toast for this to match?
Suggested change
| { defaultMessage: 'Saved role' } | |
| { defaultMessage: 'Created role' } |
There was a problem hiding this comment.
Yes, i think it makes sense to do so.
There was a problem hiding this comment.
Done in c86d79c
jeramysoucy
added
backport:all-open
jeramysoucy
approved these changes
Oct 2, 2024
x-pack/plugins/security/public/management/roles/edit_role/edit_role_page.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
…astic#194427) Closes elastic#194406 ## Summary Fix wording for Roles update toast to match button when updating an existing role. ### Screenshots <img width="746" alt="image" src="https://github.com/user-attachments/assets/674a57f3-5a5a-445a-9266-8b55526aef72"> ### Release notes Changes wording for toast message when updating an existing role successfully. The toast now matches the button to say `Updated role` --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194406
Summary
Fix wording for Roles update toast to match button when updating an existing role.
Screenshots
Release notes
Changes wording for toast message when updating an existing role successfully. The toast now matches the button to say
Updated role