[Exploratory View]Additional metrics for kpi over time (#96532) (#96786)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
elastic · Apr 12, 2021 · cbb0ece · cbb0ece
1 parent 8c7bca4
commit cbb0ece
Show file tree

Hide file tree

Showing 41 changed files with 585 additions and 512 deletions.
diff --git a/x-pack/plugins/lens/public/index.ts b/x-pack/plugins/lens/public/index.ts
@@ -33,6 +33,7 @@ export type {
   IndexPatternPersistedState,
   PersistedIndexPatternLayer,
   IndexPatternColumn,
+  FieldBasedIndexPatternColumn,
   OperationType,
   IncompleteColumn,
   FiltersIndexPatternColumn,

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/types.ts b/x-pack/plugins/lens/public/indexpattern_datasource/types.ts
@@ -11,6 +11,7 @@ import { IndexPatternAggRestrictions } from '../../../../../src/plugins/data/pub
 import { DragDropIdentifier } from '../drag_drop/providers';
 
 export {
+  FieldBasedIndexPatternColumn,
   IndexPatternColumn,
   OperationType,
   IncompleteColumn,

diff --git a/...ty/public/components/shared/exploratory_view/configurations/apm/service_latency_config.ts b/...ty/public/components/shared/exploratory_view/configurations/apm/service_latency_config.ts
@@ -8,7 +8,6 @@
 import { ConfigProps, DataSeries } from '../../types';
 import { FieldLabels } from '../constants';
 import { buildPhraseFilter } from '../utils';
-import { OperationType } from '../../../../../../../lens/public';
 
 export function getServiceLatencyLensConfig({ seriesId, indexPattern }: ConfigProps): DataSeries {
   return {
@@ -20,11 +19,11 @@ export function getServiceLatencyLensConfig({ seriesId, indexPattern }: ConfigPr
       sourceField: '@timestamp',
     },
     yAxisColumn: {
-      operationType: 'average' as OperationType,
+      operationType: 'average',
       sourceField: 'transaction.duration.us',
       label: 'Latency',
     },
-    hasMetricType: true,
+    hasOperationType: true,
     defaultFilters: [
       'user_agent.name',
       'user_agent.os.name',
@@ -37,7 +36,7 @@ export function getServiceLatencyLensConfig({ seriesId, indexPattern }: ConfigPr
       'client.geo.country_name',
       'user_agent.device.name',
     ],
-    filters: [buildPhraseFilter('transaction.type', 'request', indexPattern)],
+    filters: buildPhraseFilter('transaction.type', 'request', indexPattern),
     labels: { ...FieldLabels },
     reportDefinitions: [
       {

diff --git a/...public/components/shared/exploratory_view/configurations/apm/service_throughput_config.ts b/...public/components/shared/exploratory_view/configurations/apm/service_throughput_config.ts
@@ -8,26 +8,25 @@
 import { ConfigProps, DataSeries } from '../../types';
 import { FieldLabels } from '../constants/constants';
 import { buildPhraseFilter } from '../utils';
-import { OperationType } from '../../../../../../../lens/public';
 
 export function getServiceThroughputLensConfig({
   seriesId,
   indexPattern,
 }: ConfigProps): DataSeries {
   return {
     id: seriesId,
-    reportType: 'service-latency',
+    reportType: 'service-throughput',
     defaultSeriesType: 'line',
     seriesTypes: ['line', 'bar'],
     xAxisColumn: {
       sourceField: '@timestamp',
     },
     yAxisColumn: {
-      operationType: 'average' as OperationType,
+      operationType: 'average',
       sourceField: 'transaction.duration.us',
       label: 'Throughput',
     },
-    hasMetricType: true,
+    hasOperationType: true,
     defaultFilters: [
       'user_agent.name',
       'user_agent.os.name',
@@ -40,7 +39,7 @@ export function getServiceThroughputLensConfig({
       'client.geo.country_name',
       'user_agent.device.name',
     ],
-    filters: [buildPhraseFilter('transaction.type', 'request', indexPattern)],
+    filters: buildPhraseFilter('transaction.type', 'request', indexPattern),
     labels: { ...FieldLabels },
     reportDefinitions: [
       {

diff --git a/...rvability/public/components/shared/exploratory_view/configurations/constants/constants.ts b/...rvability/public/components/shared/exploratory_view/configurations/constants/constants.ts
@@ -8,6 +8,8 @@
 import { AppDataType, ReportViewTypeId } from '../../types';
 import { CLS_FIELD, FCP_FIELD, FID_FIELD, LCP_FIELD, TBT_FIELD } from './elasticsearch_fieldnames';
 
+export const DEFAULT_TIME = { from: 'now-1h', to: 'now' };
+
 export const FieldLabels: Record<string, string> = {
   'user_agent.name': 'Browser family',
   'user_agent.version': 'Browser version',

diff --git a/...ility/public/components/shared/exploratory_view/configurations/constants/url_constants.ts b/...ility/public/components/shared/exploratory_view/configurations/constants/url_constants.ts
@@ -6,7 +6,7 @@
  */
 
 export enum URL_KEYS {
-  METRIC_TYPE = 'mt',
+  OPERATION_TYPE = 'op',
   REPORT_TYPE = 'rt',
   SERIES_TYPE = 'st',
   BREAK_DOWN = 'bd',

diff --git a/...vability/public/components/shared/exploratory_view/configurations/lens_attributes.test.ts b/...vability/public/components/shared/exploratory_view/configurations/lens_attributes.test.ts
@@ -42,29 +42,37 @@ describe('Lens Attribute', () => {
   it('should return expected field type', function () {
     expect(JSON.stringify(lnsAttr.getFieldMeta('transaction.type'))).toEqual(
       JSON.stringify({
-        count: 0,
-        name: 'transaction.type',
-        type: 'string',
-        esTypes: ['keyword'],
-        scripted: false,
-        searchable: true,
-        aggregatable: true,
-        readFromDocValues: true,
+        fieldMeta: {
+          count: 0,
+          name: 'transaction.type',
+          type: 'string',
+          esTypes: ['keyword'],
+          scripted: false,
+          searchable: true,
+          aggregatable: true,
+          readFromDocValues: true,
+        },
+        fieldName: 'transaction.type',
+        columnType: null,
       })
     );
   });
 
   it('should return expected field type for custom field with default value', function () {
     expect(JSON.stringify(lnsAttr.getFieldMeta('performance.metric'))).toEqual(
       JSON.stringify({
-        count: 0,
-        name: 'transaction.duration.us',
-        type: 'number',
-        esTypes: ['long'],
-        scripted: false,
-        searchable: true,
-        aggregatable: true,
-        readFromDocValues: true,
+        fieldMeta: {
+          count: 0,
+          name: 'transaction.duration.us',
+          type: 'number',
+          esTypes: ['long'],
+          scripted: false,
+          searchable: true,
+          aggregatable: true,
+          readFromDocValues: true,
+        },
+        fieldName: 'transaction.duration.us',
+        columnType: null,
       })
     );
   });
@@ -76,20 +84,45 @@ describe('Lens Attribute', () => {
 
     expect(JSON.stringify(lnsAttr.getFieldMeta('performance.metric'))).toEqual(
       JSON.stringify({
-        count: 0,
-        name: LCP_FIELD,
-        type: 'number',
-        esTypes: ['scaled_float'],
-        scripted: false,
-        searchable: true,
-        aggregatable: true,
-        readFromDocValues: true,
+        fieldMeta: {
+          count: 0,
+          name: LCP_FIELD,
+          type: 'number',
+          esTypes: ['scaled_float'],
+          scripted: false,
+          searchable: true,
+          aggregatable: true,
+          readFromDocValues: true,
+        },
+        fieldName: LCP_FIELD,
       })
     );
   });
 
-  it('should return expected number column', function () {
-    expect(lnsAttr.getNumberColumn('transaction.duration.us')).toEqual({
+  it('should return expected number range column', function () {
+    expect(lnsAttr.getNumberRangeColumn('transaction.duration.us')).toEqual({
+      dataType: 'number',
+      isBucketed: true,
+      label: 'Page load time (Seconds)',
+      operationType: 'range',
+      params: {
+        maxBars: 'auto',
+        ranges: [
+          {
+            from: 0,
+            label: '',
+            to: 1000,
+          },
+        ],
+        type: 'histogram',
+      },
+      scale: 'interval',
+      sourceField: 'transaction.duration.us',
+    });
+  });
+
+  it('should return expected number operation column', function () {
+    expect(lnsAttr.getNumberRangeColumn('transaction.duration.us')).toEqual({
       dataType: 'number',
       isBucketed: true,
       label: 'Page load time (Seconds)',