[Exploratory View]Additional metrics for kpi over time #96532

shahzad31 · 2021-04-08T06:39:32Z

Summary

PR in a series of features to cover https://github.com/elastic/uptime-dev/issues/46

Added additional metric for RUM Kpi over time

Added Page view, backend time, First contentful pain, Backend time, Total blocking time, Largest contentful paint

Also improved the chart type select component by making it a select, renamed few other variables and components.

Testing

When you select Rum data type and KPI over time report type,

you should be able to plot all those additional metrics on the chart.

elasticmachine · 2021-04-08T12:56:07Z

Pinging @elastic/uptime (Team:uptime)

kibanamachine · 2021-04-12T09:51:13Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	413.8KB	416.8KB	+2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	35.1KB	35.1KB	+42.0B

History

💚 Build #118326 succeeded 7da240d
💚 Build #118193 succeeded c8678ec
💔 Build #118155 failed edef8c2
💔 Build #118123 failed f0ead1b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke

Looks great!

One thing I noticed is that if you select the "placeholder" option, you encounter this error.

This isn't a great experience. Since we already initialize the chart with a starting metric, do we need to include the placeholder as an option? Since the fields within the Definition section all have different purposes, perhaps we can label them some other way, like with EuiFormRow.

If we don't make use of EuiFormRow, we'll need to include aria-labels for the selects, as it doesn't appear as if the input fields are currently labeled in the html.

Also, sometimes the buttons spill out of their columns. This may not be as big of an issue, as I was viewing the feature at non-standard breakpoints.

dominiqueclarke · 2021-04-12T01:17:30Z

...ns/observability/public/components/shared/exploratory_view/configurations/lens_attributes.ts


    if (fieldType === 'date') {
      return this.getDateHistogramColumn(fieldName);
    }
    if (fieldType === 'number') {
-      return this.getNumberColumn(fieldName);
+      if (columnType === 'operation' || operationType) {


This is starting to get nested pretty deep. Any alternatives?

it's indeed, i am hoping Lens team can expose these small utils to make embeddable component life easy. May have to contribute myself there, especially these build column utils.

dominiqueclarke · 2021-04-12T01:20:34Z

...bility/public/components/shared/exploratory_view/series_builder/columns/chart_types.test.tsx


-describe.skip('SeriesChartTypes', function () {
+describe.skip('SeriesChartTypesSelect', function () {


Why are these skipped currently?

i had skipped these as well because of getByRole slowness, i wasn't earlier sure why it's happening so make CI happy, i did that, will unskip in a follow up.

dominiqueclarke · 2021-04-12T01:23:05Z

...servability/public/components/shared/exploratory_view/series_builder/columns/chart_types.tsx

+
+  const { data = [], loading } = useFetcher(() => lens.getXyVisTypes(), [lens]);
+
+  let vizTypes = data ?? [];


Not sure you need this with the above default assignment.

++, will remove this.

flash1293

Exposing FieldBasedIndexPatternColumn sounds good to me, code LGTM.

dominiqueclarke

LGTM

shahzad31 · 2021-04-12T13:46:41Z

Looks great!

One thing I noticed is that if you select the "placeholder" option, you encounter this error.

This isn't a great experience. Since we already initialize the chart with a starting metric, do we need to include the placeholder as an option? Since the fields within the Definition section all have different purposes, perhaps we can label them some other way, like with EuiFormRow.

@dominiqueclarke i will address these in a follow up #96782, that should be the last PR as a follow up before FF, at that point we can decide the state of things and see if we want to link actual charts to this or keep it hidden behind URL.

…to-metrics-tab * 'master' of github.com:elastic/kibana: (44 commits) [Exploratory View]Additional metrics for kpi over time (elastic#96532) [Fleet] UI changes on hosted policy detail view (elastic#96337) Stacked line charts incorrectly shows one term as 100% (elastic#96203) [Fleet] Create enrollment API keys as current user (elastic#96464) [Lens] Make table and metric show on top Chart switcher (elastic#96601) skip flaky suite (elastic#96691) [Lens] Hide "Show more errors" once expanded (elastic#96605) [Discover] Unskip histogram hiding test (elastic#95759) skip flyout test, add linked issue elastic#96708 skip copy_to_space_flyout_internal.test.tsx elastic#96708 fix config validation (elastic#96502) Document telemetry fields for stack security features (elastic#96638) [Partial Results] Move inspector adapter integration into search source (elastic#96241) [RAC] Rule registry plugin (elastic#95903) [APM] Run precommit tasks sequentially (elastic#96551) [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633) [Security Solution] [Cases] Small UI bugfixes (elastic#96511) [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363) App Search: Result Component Updates (elastic#96184) [Alerting] Preconfigured alert history index connector (elastic#94909) ...

kibanamachine · 2021-04-12T13:56:28Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>

shahzad31 added 30 commits March 7, 2021 11:40

wip

9e7c169

Merge branch 'master' into exploratry-view

12c028f

Save progress

b089a87

Merge branch 'master' into exploratry-view

501a166

breakpoint

3ed7c82

Merge branch 'master' into exploratry-view

c303383

more views

73b2c41

add def col

9166efc

Merge branch 'master' into exploratry-view

3783b5f

update

04316ab

Merge branch 'master' into exploratry-view

9677edd

wip

e715ace

Merge branch 'master' into exploratry-view

5d3605f

wip

3d824be

Merge branch 'master' into exploratry-view

1db17ad

wip

306fa3f

Merge branch 'master' into exploratry-view

e2f281f

fix more stuff

700cdd7

Merge branch 'master' into exploratry-view

ee82e77

update

1d5a7c8

Merge branch 'master' into exploratry-view

91bcf95

update filters

2ec3924

update

4f8f118

wip

b2fbc2b

update

e5c1e59

update asset

c14a2e5

update

165a540

update eslint

e3b3eb5

Merge branch 'master' into exploratry-view

4b8aab4

udate

84c2abe

shahzad31 added 2 commits April 8, 2021 11:50

update kp

edef8c2

fix test

af326a9

shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 8, 2021

shahzad31 self-assigned this Apr 8, 2021

shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Apr 8, 2021

shahzad31 added 2 commits April 8, 2021 14:01

fix test

c5ae1f3

i18n

c8678ec

shahzad31 marked this pull request as ready for review April 8, 2021 12:56

shahzad31 requested a review from a team April 8, 2021 12:56

shahzad31 requested a review from dominiqueclarke April 8, 2021 12:56

shahzad31 added 2 commits April 8, 2021 18:58

fix loading issues

7da240d

Merge branch 'master' into additional-metrics-for-kpi

e413d18

dominiqueclarke reviewed Apr 12, 2021

View reviewed changes

flash1293 approved these changes Apr 12, 2021

View reviewed changes

dominiqueclarke approved these changes Apr 12, 2021

View reviewed changes

shahzad31 merged commit a2c47ef into elastic:master Apr 12, 2021

shahzad31 deleted the additional-metrics-for-kpi branch April 12, 2021 13:53

shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 12, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 12, 2021

[Exploratory View]Additional metrics for kpi over time (elastic#96532)

be73ab9

kibanamachine mentioned this pull request Apr 12, 2021

[7.x] [Exploratory View]Additional metrics for kpi over time (#96532) #96786

Merged

kibanamachine added a commit that referenced this pull request Apr 12, 2021

[Exploratory View]Additional metrics for kpi over time (#96532) (#96786)

cbb0ece

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>

shahzad31 restored the additional-metrics-for-kpi branch April 14, 2021 15:18

shahzad31 deleted the additional-metrics-for-kpi branch April 15, 2021 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Exploratory View]Additional metrics for kpi over time #96532

[Exploratory View]Additional metrics for kpi over time #96532

shahzad31 commented Apr 8, 2021 •

edited

Loading

elasticmachine commented Apr 8, 2021

kibanamachine commented Apr 12, 2021

dominiqueclarke left a comment

dominiqueclarke Apr 12, 2021

shahzad31 Apr 12, 2021

dominiqueclarke Apr 12, 2021

shahzad31 Apr 12, 2021

dominiqueclarke Apr 12, 2021

shahzad31 Apr 12, 2021

flash1293 left a comment

dominiqueclarke left a comment

shahzad31 commented Apr 12, 2021

kibanamachine commented Apr 12, 2021


		describe.skip('SeriesChartTypes', function () {
		describe.skip('SeriesChartTypesSelect', function () {


		const { data = [], loading } = useFetcher(() => lens.getXyVisTypes(), [lens]);

		let vizTypes = data ?? [];

[Exploratory View]Additional metrics for kpi over time #96532

[Exploratory View]Additional metrics for kpi over time #96532

Conversation

shahzad31 commented Apr 8, 2021 • edited Loading

Summary

Testing

elasticmachine commented Apr 8, 2021

kibanamachine commented Apr 12, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

dominiqueclarke left a comment

Choose a reason for hiding this comment

dominiqueclarke Apr 12, 2021

Choose a reason for hiding this comment

shahzad31 Apr 12, 2021

Choose a reason for hiding this comment

dominiqueclarke Apr 12, 2021

Choose a reason for hiding this comment

shahzad31 Apr 12, 2021

Choose a reason for hiding this comment

dominiqueclarke Apr 12, 2021

Choose a reason for hiding this comment

shahzad31 Apr 12, 2021

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

dominiqueclarke left a comment

Choose a reason for hiding this comment

shahzad31 commented Apr 12, 2021

kibanamachine commented Apr 12, 2021

💚 Backport successful

shahzad31 commented Apr 8, 2021 •

edited

Loading