Skip to content

Commit

Permalink
[8.7] [Discover] Remove redundant "Filter was added" toast (#155645) (#…
Browse files Browse the repository at this point in the history
…155825)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Discover] Remove redundant "Filter was added" toast
(#155645)](#155645)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-04-26T06:30:55Z","message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or
sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":155645,"url":"https://github.com/elastic/kibana/pull/155645","mergeCommit":{"message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or
sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155645","number":155645,"mergeCommit":{"message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
  • Loading branch information
kibanamachine and jughosta authored Apr 26, 2023
1 parent efcabab commit ce77b30
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -217,18 +217,7 @@ export function DiscoverGridFlyout({
hit={actualHit}
columns={columns}
dataView={dataView}
filter={
onFilter
? (mapping, value, mode) => {
onFilter(mapping, value, mode);
services.toastNotifications.addSuccess(
i18n.translate('discover.grid.flyout.toastFilterAdded', {
defaultMessage: `Filter was added`,
})
);
}
: undefined
}
filter={onFilter}
onRemoveColumn={(columnName: string) => {
onRemoveColumn(columnName);
services.toastNotifications.addSuccess(
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -2393,7 +2393,6 @@
"discover.grid.flyout.documentNavigation": "Navigation dans le document",
"discover.grid.flyout.toastColumnAdded": "La colonne \"{columnName}\" a été ajoutée.",
"discover.grid.flyout.toastColumnRemoved": "La colonne \"{columnName}\" a été supprimée.",
"discover.grid.flyout.toastFilterAdded": "Le filtre a été ajouté.",
"discover.grid.selectDoc": "Sélectionner le document \"{rowNumber}\"",
"discover.grid.tableRow.detailHeading": "Document développé",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "Document unique",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -2393,7 +2393,6 @@
"discover.grid.flyout.documentNavigation": "ドキュメントナビゲーション",
"discover.grid.flyout.toastColumnAdded": "列'{columnName}'が追加されました",
"discover.grid.flyout.toastColumnRemoved": "列'{columnName}'が削除されました",
"discover.grid.flyout.toastFilterAdded": "フィルターが追加されました",
"discover.grid.selectDoc": "ドキュメント'{rowNumber}'を選択",
"discover.grid.tableRow.detailHeading": "拡張ドキュメント",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "1つのドキュメント",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -2393,7 +2393,6 @@
"discover.grid.flyout.documentNavigation": "文档导航",
"discover.grid.flyout.toastColumnAdded": "已添加列“{columnName}”",
"discover.grid.flyout.toastColumnRemoved": "已移除列“{columnName}”",
"discover.grid.flyout.toastFilterAdded": "已添加筛选",
"discover.grid.selectDoc": "选择文档“{rowNumber}”",
"discover.grid.tableRow.detailHeading": "已展开文档",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "单个文档",
Expand Down

0 comments on commit ce77b30

Please sign in to comment.