[Discover] Remove redundant "Filter was added" toast #155645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
Feature:Discover
jughosta
changed the title
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @jughosta |
davismcphee
approved these changes
Apr 25, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 26, 2023
Closes elastic#154993 ## Summary This PR removes "Filter was added" toast (it was visible after adding filters from the Doc Viewer flyout) which was not very useful. It's also not shown when user adds filters from the grid or sidebar. (cherry picked from commit 7534cc7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 26, 2023
…155825) # Backport This will backport the following commits from `main` to `8.7`: - [[Discover] Remove redundant "Filter was added" toast (#155645)](#155645) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-04-26T06:30:55Z","message":"[Discover] Remove redundant \"Filter was added\" toast (#155645)\n\nCloses https://github.com/elastic/kibana/issues/154993\r\n\r\n## Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was visible after adding\r\nfilters from the Doc Viewer flyout) which was not very useful. It's also\r\nnot shown when user adds filters from the grid or sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":155645,"url":"https://github.com/elastic/kibana/pull/155645","mergeCommit":{"message":"[Discover] Remove redundant \"Filter was added\" toast (#155645)\n\nCloses https://github.com/elastic/kibana/issues/154993\r\n\r\n## Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was visible after adding\r\nfilters from the Doc Viewer flyout) which was not very useful. It's also\r\nnot shown when user adds filters from the grid or sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155645","number":155645,"mergeCommit":{"message":"[Discover] Remove redundant \"Filter was added\" toast (#155645)\n\nCloses https://github.com/elastic/kibana/issues/154993\r\n\r\n## Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was visible after adding\r\nfilters from the Doc Viewer flyout) which was not very useful. It's also\r\nnot shown when user adds filters from the grid or sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 26, 2023
* main: (1294 commits) [SecuritySolution] Refactor security packages (elastic#155365) [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717) [RAM] Conditional actions feedback on pr review (elastic#155804) [Files] Adds bulk delete method (elastic#155628) [Lens] Use proper way to generate absolute short URL (elastic#155512) [Guided onboarding] Use Kibana features to grant access (elastic#155065) [Index Management] Fix duped mock (elastic#155844) [Lens] Enhance visualization modifier popup with layer palette (elastic#155280) Fix flaky combobox tests on role management screen (elastic#155711) [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126) [Fleet] always create agent upload write indices (elastic#155729) [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045) Add tech preview label for search applications (elastic#155649) [ML] AIOps: Stabilize flaky functional tests. (elastic#155710) [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610) [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814) [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800) Remove Exploratory View components from Observability (elastic#155629) [Discover] Remove redundant "Filter was added" toast (elastic#155645) [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154993
Summary
This PR removes "Filter was added" toast (it was visible after adding filters from the Doc Viewer flyout) which was not very useful. It's also not shown when user adds filters from the grid or sidebar.