Skip to content

Commit

Permalink
[ML] Transform: Remove duplicate page main landmarks (#56883)
Browse files Browse the repository at this point in the history 
* [ML] Transform: Remove duplicate page main landmarks

* [ML] Removed unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
  • Loading branch information
@peteharverson @elasticmachine
peteharverson and elasticmachine authored Feb 6, 2020
1 parent ce95f12 commit e92ead7
Show file tree
Hide file tree
Showing 2 changed files with 104 additions and 110 deletions.
93 changes: 45 additions & 48 deletions ...egacy/plugins/transform/public/app/sections/create_transform/create_transform_section.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiPageContent,
EuiPageBody,
EuiPageContentBody,
EuiSpacer,
EuiTitle,
Expand All @@ -41,53 +40,51 @@ export const CreateTransformSection: FC<Props> = ({ match }) => {
return (
<PrivilegesWrapper privileges={APP_CREATE_TRANSFORM_CLUSTER_PRIVILEGES}>
<KibanaProvider savedObjectId={match.params.savedObjectId}>
<EuiPageBody data-test-subj="transformPageCreateTransform">
<EuiPageContent>
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1>
<FormattedMessage
id="xpack.transform.transformsWizard.createTransformTitle"
defaultMessage="Create transform"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformsWizard.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformsWizard.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformsWizard.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<RenderOnlyWithInitializedKibanaContext>
<Wizard />
</RenderOnlyWithInitializedKibanaContext>
</EuiPageContentBody>
</EuiPageContent>
</EuiPageBody>
<EuiPageContent data-test-subj="transformPageCreateTransform">
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1>
<FormattedMessage
id="xpack.transform.transformsWizard.createTransformTitle"
defaultMessage="Create transform"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformsWizard.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformsWizard.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformsWizard.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<RenderOnlyWithInitializedKibanaContext>
<Wizard />
</RenderOnlyWithInitializedKibanaContext>
</EuiPageContentBody>
</EuiPageContent>
</KibanaProvider>
</PrivilegesWrapper>
);
Expand Down
121 changes: 59 additions & 62 deletions ...ugins/transform/public/app/sections/transform_management/transform_management_section.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
EuiFlexItem,
EuiModal,
EuiOverlayMask,
EuiPageBody,
EuiPageContent,
EuiPageContentBody,
EuiSpacer,
Expand Down Expand Up @@ -74,68 +73,66 @@ export const TransformManagement: FC = () => {

return (
<Fragment>
<EuiPageBody data-test-subj="transformPageTransformList">
<EuiPageContent>
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1 data-test-subj="transformAppTitle">
<FormattedMessage
id="xpack.transform.transformList.transformTitle"
defaultMessage="Transforms"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformList.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformList.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformList.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiSpacer size="s" />
<EuiTitle size="s">
<EuiText color="subdued">
<FormattedMessage
id="xpack.transform.transformList.transformDescription"
defaultMessage="Use transforms to pivot existing Elasticsearch indices into summarized or entity-centric indices."
/>
</EuiText>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<TransformStatsBar transformsList={transforms} />
<EuiSpacer size="s" />
<TransformList
errorMessage={errorMessage}
isInitialized={isInitialized}
onCreateTransform={onOpenModal}
transforms={transforms}
transformsLoading={transformsLoading}
<EuiPageContent data-test-subj="transformPageTransformList">
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1 data-test-subj="transformAppTitle">
<FormattedMessage
id="xpack.transform.transformList.transformTitle"
defaultMessage="Transforms"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformList.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformList.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformList.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiSpacer size="s" />
<EuiTitle size="s">
<EuiText color="subdued">
<FormattedMessage
id="xpack.transform.transformList.transformDescription"
defaultMessage="Use transforms to pivot existing Elasticsearch indices into summarized or entity-centric indices."
/>
</EuiPageContentBody>
</EuiPageContent>
</EuiPageBody>
</EuiText>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<TransformStatsBar transformsList={transforms} />
<EuiSpacer size="s" />
<TransformList
errorMessage={errorMessage}
isInitialized={isInitialized}
onCreateTransform={onOpenModal}
transforms={transforms}
transformsLoading={transformsLoading}
/>
</EuiPageContentBody>
</EuiPageContent>
{isSearchSelectionVisible && (
<EuiOverlayMask>
<EuiModal
Expand Down

0 comments on commit e92ead7

Please sign in to comment.