Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transform: Remove duplicate page main landmarks #56883

Merged
merged 3 commits into from
Feb 6, 2020
Merged

[ML] Transform: Remove duplicate page main landmarks #56883

merged 3 commits into from
Feb 6, 2020

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Feb 5, 2020 •
edited
Loading

Summary

Part of #37539 and #52278, removes the duplicate <main> landmarksfrom the Transform management and Create transform page. These pages are rendered inside the management page structure which itself adds a <main> landmark.

Page structure was checked using the WAVE extension on Chrome.

Checklist

For maintainers

@peteharverson peteharverson requested a review from a team as a code owner February 5, 2020 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

darnautov
darnautov approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@peteharverson peteharverson merged commit e92ead7 into elastic:master Feb 6, 2020
@peteharverson peteharverson deleted the transforms-fix-duplicate-main branch February 6, 2020 15:48
@peteharverson peteharverson mentioned this pull request Feb 6, 2020
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Feb 6, 2020
@peteharverson @elasticmachine
[ML] Transform: Remove duplicate page main landmarks (elastic#56883)
e3a4bf1 
* [ML] Transform: Remove duplicate page main landmarks

* [ML] Removed unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
peteharverson added a commit that referenced this pull request Feb 7, 2020
@peteharverson @elasticmachine
[ML] Transform: Remove duplicate page main landmarks (#56883) (#56992)
7a35882 
* [ML] Transform: Remove duplicate page main landmarks

* [ML] Removed unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@peteharverson peteharverson mentioned this pull request Feb 24, 2020
Closed
18 tasks
@peteharverson peteharverson mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov darnautov approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees
No one assigned
Labels
Feature:Transforms ML transforms :ml Project:Accessibility release_note:fix review v7.7.0 v8.0.0 WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @kibanamachine @darnautov @alvarezmelissa87