[Share] The redirect app path should not appear in the browser history (

#117155) (#117310) * the redirect app path should not appear in the browser history * updated jest test to also expect replace * added comment * update jest test
elastic · Nov 3, 2021 · ea7c26d · ea7c26d
1 parent 9349ed6
commit ea7c26d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/plugins/share/public/url_service/redirect/redirect_manager.test.ts b/src/plugins/share/public/url_service/redirect/redirect_manager.test.ts
@@ -57,9 +57,12 @@ describe('on page mount', () => {
         })
       )}`
     );
-    expect(spy).toHaveBeenCalledWith({
-      foo: 'bar',
-    });
+    expect(spy).toHaveBeenCalledWith(
+      {
+        foo: 'bar',
+      },
+      { replace: true }
+    );
   });
 
   test('migrates parameters on-the-fly to the latest version', async () => {
@@ -73,9 +76,12 @@ describe('on page mount', () => {
         })
       )}`
     );
-    expect(spy).toHaveBeenCalledWith({
-      num: 2,
-    });
+    expect(spy).toHaveBeenCalledWith(
+      {
+        num: 2,
+      },
+      { replace: true }
+    );
   });
 
   test('throws if locator does not exist', async () => {

diff --git a/src/plugins/share/public/url_service/redirect/redirect_manager.ts b/src/plugins/share/public/url_service/redirect/redirect_manager.ts
@@ -66,7 +66,9 @@ export class RedirectManager {
     });
 
     locator
-      .navigate(migratedParams)
+      .navigate(migratedParams, {
+        replace: true, // We do not want the redirect app URL to appear in browser navigation history
+      })
       .then()
       .catch((error) => {
         // eslint-disable-next-line no-console