Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 'Copy to Clipboard' button to Discover for all field types #108857

Closed
aarju opened this issue Aug 17, 2021 · 2 comments · Fixed by #149525
Closed

Add a 'Copy to Clipboard' button to Discover for all field types #108857

aarju opened this issue Aug 17, 2021 · 2 comments · Fixed by #149525
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@aarju
Copy link

aarju commented Aug 17, 2021

Describe the feature:
Add the Copy to Clipboard button that we currently have for Array field types to all field types.

Copy to Clipboard

Describe a specific use case for the feature:

A user wants to copy the contents of a field in the new Discover table view so they expand the field and then click the 'copy to clipboard' button. Ideally this could also have a keyboard shortcut of ctrl+c for the currently highlighted field.
@aarju aarju added the Feature:Discover Discover Application label Aug 17, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 17, 2021
@timroes timroes added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed needs-team Issues missing a team label labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this issue Aug 18, 2021
Closed
41 tasks
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal
Copy link
Member

kertal commented May 10, 2022

related PR #131899

@kertal kertal mentioned this issue Dec 6, 2022
Closed
2 tasks
@davismcphee davismcphee added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 7, 2022
@jughosta jughosta mentioned this issue Jan 25, 2023
Merged
3 tasks
jughosta added a commit that referenced this issue Jan 30, 2023
@jughosta
[Discover] Show "Copy value" button for any grid cell (#149525)
82a4c5e 
Closes #108857

## Summary

Before we had "Copy to clipboard" only for cell popovers with JSON
content. This PR adds it also for any other cell values.

![Jan-25-2023
18-23-03](https://user-images.githubusercontent.com/1415710/214636400-b347e856-8bf0-4038-bc41-aae23df5e5a9.gif)

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
@jughosta @kqualters-elastic
[Discover] Show "Copy value" button for any grid cell (elastic#149525)
9f2b582 
Closes elastic#108857

## Summary

Before we had "Copy to clipboard" only for cell popovers with JSON
content. This PR adds it also for any other cell values.

![Jan-25-2023
18-23-03](https://user-images.githubusercontent.com/1415710/214636400-b347e856-8bf0-4038-bc41-aae23df5e5a9.gif)

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Show "Copy value" button for any grid cell jughosta/kibana
6 participants
@kertal @timroes @jughosta @aarju @elasticmachine @davismcphee