Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB: Dark theme styling stopped working with visualize refactor #12802

Closed
simianhacker opened this issue Jul 12, 2017 · 0 comments · Fixed by #12804
Closed

TSVB: Dark theme styling stopped working with visualize refactor #12802

simianhacker opened this issue Jul 12, 2017 · 0 comments · Fixed by #12804
Assignees
@simianhacker
Labels
blocker Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.0.0-beta1 v6.0.0

Comments

@simianhacker
Copy link
Member

simianhacker commented Jul 12, 2017 •
edited
Loading

When using a TSVB visualization on a dark themed dashboard the reversed attribute is not being passed to the visualizations. This broke with #11786

image

This was being set using: https://github.com/elastic/kibana/blob/5.5/src/core_plugins/metrics/public/kbn_vis_types/vis_controller.js#L23-L27
@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) blocker v6.0.0 v6.0.0-beta1 labels Jul 12, 2017
@simianhacker simianhacker self-assigned this Jul 12, 2017
simianhacker added a commit to simianhacker/kibana that referenced this issue Jul 12, 2017
@simianhacker
Fixes elastic#12802 - Fix TSVB Visualizations to honor darkTheme
e0502ab
@simianhacker simianhacker mentioned this issue Jul 12, 2017
Merged
simianhacker added a commit that referenced this issue Jul 12, 2017
@simianhacker
Fix TSVB Visualizations to honor darkTheme (#12804)
5e6a097 
* Fixes #12802 - Fix TSVB Visualizations to honor darkTheme

* Sometimes appState doesn't exist

* Fixes #12762 - Fixing propTypes to match props being passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

Labels
blocker Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.0.0-beta1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TSVB Visualizations to honor darkTheme simianhacker/kibana
1 participant
@simianhacker