Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TSVB Visualizations to honor darkTheme #12804

Merged
merged 3 commits into from
Jul 12, 2017
Merged

Fix TSVB Visualizations to honor darkTheme #12804

merged 3 commits into from
Jul 12, 2017

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jul 12, 2017 •
edited
Loading

This PR fixes TSVB to honor the darkTheme for dashboards. It also setups up the react_vis_type to pass appState as an argument to the component.

Closes #12802
Closes #12762

Before:

image

After:

image

@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) blocker release_note:fix v6.0.0 v6.0.0-beta1 labels Jul 12, 2017
@simianhacker simianhacker merged commit 5e6a097 into elastic:master Jul 12, 2017
@simianhacker simianhacker deleted the fix-12802 branch July 12, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck Awaiting requested review from thomasneirynck

Assignees
No one assigned
Labels
blocker Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix v6.0.0-beta1 v6.0.0
Projects
None yet
Milestone
No milestone
1 participant
@simianhacker