Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Query toggle, responsive design issues #131405

Closed
stephmilovic opened this issue May 3, 2022 · 5 comments
Closed

[Security Solution] Query toggle, responsive design issues #131405

stephmilovic opened this issue May 3, 2022 · 5 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.2.1 v8.3.0

Comments

@stephmilovic
Copy link
Contributor

stephmilovic commented May 3, 2022

There are responsive design issues with the query toggle button and headings on the tables in Explore area. General cleanup needed. See screenshots:
Screen Shot 2022-05-03 at 7 50 10 AM
Screen Shot 2022-05-03 at 7 50 41 AM
Screen Shot 2022-05-03 at 7 50 47 AM

remove all related workarounds by searching for: ticket number #131405 in the code base (within detection response: x-pack/plugins/security_solution/public/overview/components/detection_response/ )

@stephmilovic stephmilovic added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.3.0 v8.2.1 labels May 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Contributor Author

tested the fix, but i also did the fix so idk that i should close this @MadameSheema ??

@ghost
Copy link

ghost commented May 19, 2022

Hi @stephmilovic,

We have validated above issue on 8.2.1 BC1 build and and found that it's still occurring 🔴.

Below are the observations about the Explore area on smaller screens (here screen size is 400 x 666):

  1. Toggle icon should be before the alerts trend and events name. (refer Screenshot 1)
  • Detection alerts trend Fail
  • External alerts trend Fail
  • Events Fail
  • Host events Fail
  • Network events Fail
  1. Alerts trend and Events name should be shown on de-expanding the toggle. (refer Screenshot 1)
  • Detection alerts trend Fail
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass
  1. Alerts trend and Events name should be shown inside the box on de-expanding the toggle. (refer Screenshot 1)
  • Detection alerts trend Fail
  • External alerts trend Pass
  • Events Pass
  • Host events Fail
  • Network events Fail
  1. Closed alignment of box should be there for Alerts trend and Events name. There should not be lot of space in the box on de-expanding the toggle. (refer Screenshot 1)
  • Detection alerts trend Pass
  • External alerts trend Fail
  • Events Fail
  • Host events Fail
  • Network events Fail
  1. Alignment of sub parts of events should be correct. (refer Video 1)
  • Host events Pass
  • Network events Pass
  1. Puts the number and bar on the same line for sub parts of events. (refer Screenshot 2)
  • Host events Fail
  • Network events Fail

Build info:

Version: 8.2.1 BC1
Build: 52170
Commit: 88889128ccda6f7e13983b0087e9aaa183818473

Screenshots:

Screenshot 1:

image

Video 1:

Overview.-.Kibana.-.Google.Chrome.2022-05-19.14-39-41.mp4

Screenshot 2:

image

Thanks!

@ghost
Copy link

ghost commented May 20, 2022

Hi @stephmilovic,

We have validated above issue on 8.2.1 Staging BC2 build and and found that it's still occurring 🔴.

Below are the observations about the Explore area on smaller screens (here screen size is 400 x 666):

  1. Toggle icon should be before the alerts trend and events name. (refer Screenshot 1)
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass
  1. Alerts trend and Events name should be shown on de-expanding the toggle. (refer Screenshot 1)
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass
  1. Alerts trend and Events name should be shown inside the box on de-expanding the toggle. (refer Screenshot 1)
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass
  1. Closed alignment of box should be there for Alerts trend and Events name. There should not be lot of space in the box on de-expanding the toggle. (refer Screenshot 1)
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass
  1. Alignment of sub parts of events should be correct. (refer Video 1)
  • Host events Pass
  • Network events Pass
  1. Puts the number and bar on the same line for sub parts of events. But there is a gap between number and bar. (refer Screenshot 2)
  • Host events Fail
  • Network events Fail

Build info:

Version: 8.2.1 BC2
Build: 52192
Commit: d4427fadd63ee9face4438cb3a4e17aaec93afe4

Screenshots:

Screenshot 1:

image

Video 1:

Overview.-.Kibana.-.Google.Chrome.2022-05-20.14-29-42.mp4

Screenshot 2:

image

Thanks!

@ghost
Copy link

ghost commented Jun 3, 2022

Hi @stephmilovic,

We have validated above issue on 8.3.0 BC2 and and found that it's still occurring 🔴.

Build info:

Version: 8.3.0 BC2
Build: 53231
Commit: 25476b531ba9f32292bde85508d342aa5e1c29eb

Below are the observations about the Explore area on smaller screens (here screen size is 400 x 666):

  1. Toggle icon should be before the alerts trend and events name.
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass

image

  1. Alerts trend and Events name should be shown on de-expanding the toggle.
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass

image

  1. Alerts trend and Events name should be shown inside the box on de-expanding the toggle.
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass

image

  1. Closed alignment of box should be there for Alerts trend and Events name. There should not be lot of space in the box on de-expanding the toggle.
  • Detection alerts trend Pass
  • External alerts trend Pass
  • Events Pass
  • Host events Pass
  • Network events Pass

image

  1. Alignment of sub parts of events should be correct.
  • Host events Pass
  • Network events Pass
VM.Prachi.1.-.ec2-54-90-253-174.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2022-06-03.12-29-18.mp4
  1. Puts the number and bar on the same line for sub parts of events. But there is a gap between number and bar.
  • Host events Fail
  • Network events Fail

image

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.2.1 v8.3.0
Projects
None yet
Development

No branches or pull requests

3 participants