Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show toasts when there are missing indices #151670

Closed
kertal opened this issue Feb 21, 2023 · 1 comment · Fixed by #151788
Closed

Don't show toasts when there are missing indices #151670

kertal opened this issue Feb 21, 2023 · 1 comment · Fixed by #151788
Assignees
@kertal
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Feb 21, 2023 •
edited
Loading

We recently decided to declassify missing indices as errors.

This causes various toast storms like this:

Image

There are several ways to archieve this e.g.

kibana/src/plugins/data_views/server/routes/fields_for.ts

Line 87 in 9a5df11

allow_no_indices: allowNoIndex || false,

Could be changed to

allow_no_indices: allowNoIndex !== false

This way, given the allowNoIndex is set, it would be used, while if it's undefined, the new default would be true

Alternatively @mattkime suggested to apply this at the following parts of the code:

kibana/src/plugins/data_views/common/data_views/data_views.ts

Line 533 in 668fe89

allowNoIndex: dataView.allowNoIndex,

kibana/src/plugins/data_views/common/data_views/data_views.ts

Line 546 in 668fe89

allowNoIndex: options.allowNoIndex,

As a follow up, for cases that would need the information about missing indices it's recommended to create a function in the data views API to check for that, so consumers are able to display the information about that state.
@kertal kertal added the Feature:Discover Discover Application label Feb 21, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 21, 2023
@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed needs-team Issues missing a team label labels Feb 21, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 21, 2023
@kertal kertal added enhancement New value added to drive a business result and removed needs-team Issues missing a team label labels Feb 21, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 21, 2023
@kertal kertal added loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 21, 2023
@kertal kertal assigned kertal and unassigned mattkime Feb 22, 2023
@kertal kertal changed the title Set allowNoIndex default to true when requesting fields in data views API Don't show toasts when there are missing indices Feb 22, 2023
@kertal kertal mentioned this issue Feb 22, 2023
Merged
1 task
@mattkime mattkime mentioned this issue Feb 24, 2023
Merged
1 task
mattkime added a commit that referenced this issue Mar 24, 2023
@mattkime @kibanamachine
[data views] Automatic loading of field lists will no longer error on…
9f8b44d 
… empty field list (#152059)

## Summary

Part of #151670
and follow up to #151788

When a data view is loaded, it automatically loads its field list.
Previously, it would error if the index pattern failed to match an
index. Going forward, this will be treated as a valid empty state -
`allowNoIndices` is being passed to the field_caps requests. When
`allowNoIndices` is set to true, ES will return a valid empty set rather
than a 404 error.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jennypavlova pushed a commit to jennypavlova/kibana that referenced this issue Mar 24, 2023
@mattkime @kibanamachine @jennypavlova
[data views] Automatic loading of field lists will no longer error on…
04c8ed7 
… empty field list (elastic#152059)

## Summary

Part of elastic#151670
and follow up to elastic#151788

When a data view is loaded, it automatically loads its field list.
Previously, it would error if the index pattern failed to match an
index. Going forward, this will be treated as a valid empty state -
`allowNoIndices` is being passed to the field_caps requests. When
`allowNoIndices` is set to true, ES will return a valid empty set rather
than a 404 error.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kertal kertal

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataViews] Remove No matching indices found toasts 🍞 kertal/kibana
3 participants
@mattkime @kertal @elasticmachine