[data views] Automatic loading of field lists will no longer error on empty field list

[mattkime]

Summary

Part of #151670
and follow up to #151788

When a data view is loaded, it automatically loads its field list. Previously, it would error if the index pattern failed to match an index. Going forward, this will be treated as a valid empty state - allowNoIndices is being passed to the field_caps requests. When allowNoIndices is set to true, ES will return a valid empty set rather than a 404 error.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[kertal]

Code LGTM 👍 Question while testing, field list is still displaying an warning, wouldn't this be another opportunity ?

[mattkime]

@kertal I didn't want to change public api method behavior in case some code depends upon the failures. I guess I'm not up to speed on how the field list needs to handle this specific case.

[kertal]

Wouldn't it be an opportunity to also clean change this, so maybe a follow up email to the one of @davismcphee, that we also change the behavior of this method. Now we have the attention? If we don't do this we would need to catch the error state in the field list, right @jughosta ?

[jughosta]

@kertal Yes, the warning in the field list is shown because there was a caught exception https://github.com/elastic/kibana/blob/main/src/plugins/unified_field_list/public/hooks/use_existing_fields.ts#L164

I'm fine with both: keeping a warning or setting allowNoIndices: true for getFieldsForIndexPattern too. Looks like there are only 2 consumers of it in Kibana code base.

[kertal]

@jughosta you're right, just 2 consumers, and one is unified field list, 2nd:

[getFieldsForIndexPattern](

kibana/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/logic/use_exception_flyout_data.tsx

Lines 97 to 109 in 84efdaa

	if (activeSpaceId !== '' && memoDataViewId) {
	setDataViewLoading(true);
	const dv = await data.dataViews.get(memoDataViewId);
	const fieldsWithUnmappedInfo = await data.dataViews.getFieldsForIndexPattern(dv, {
	pattern: '',
	includeUnmapped: true,
	});
	setDataViewLoading(false);
	setDataViewIndexPatterns({
	...dv,
	fields: fieldsWithUnmappedInfo,
	});
	}

)

Here includeUnmapped is explicitly set to true, so it doesn't depend on the failure, it prevents it, so no reason not to change the default behavior

[mattkime]

@kertal Thats what I get for not looking, I made the change.

[kertal]

Code LGTM, thanks, not also the requests no longer errors, so

Before there was an error in the network panel:

Now it's fine:

Also there's no more warning in the sidebar / unified field list, which is also our desired behavior. Missing indices are no longer an error state. Mission accomplished

[kertal]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: b10dcfb

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dataViews	43.9KB	43.8KB	-42.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
securitySolution	433	436	+3

Total ESLint disabled count

id	before	after	diff
securitySolution	513	516	+3

History

• 💚 Build #115120 succeeded c983b4a
• 💔 Build #115003 failed 953e23b
• 💚 Build #114885 succeeded 65905f9
• 💛 Build #114853 was flaky c816a48
• 💔 Build #114636 failed 54684ff
• 💔 Build #114533 failed 0e0d3cf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime