Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Toast storm occurs when copying URL with state:storeInSessionStorage enabled #153073

Closed
davismcphee opened this issue Mar 10, 2023 · 1 comment · Fixed by #154792
Closed

[Discover] Toast storm occurs when copying URL with state:storeInSessionStorage enabled #153073

davismcphee opened this issue Mar 10, 2023 · 1 comment · Fixed by #154792
Assignees
@lukasolson
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@davismcphee
Copy link
Contributor

A toast storm occurs in Discover when copying the URL with state:storeInSessionStorage enabled.

Steps to reproduce:

  • Enable state:storeInSessionStorage in Advanced Settings.
  • Navigate to Discover and copy the current URL.
  • Open a new window and paste the copied URL into the address bar.
  • Observe the toast storm that occurs in Discover on load.

storm

The responsible code is located here:

kibana/src/plugins/kibana_utils/public/state_management/state_hash/state_hash.ts

Lines 16 to 21 in 503b466

throw new Error(
i18n.translate('kibana_utils.stateManagement.stateHash.unableToRestoreUrlErrorMessage', {
defaultMessage:
'Unable to completely restore the URL, be sure to use the share functionality.',
})
);

We may be able to deal with this in a similar way as the fix in #152983.
@davismcphee davismcphee added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week labels Mar 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson mentioned this issue Apr 12, 2023
Merged
1 task
lukasolson added a commit that referenced this issue Apr 13, 2023
@lukasolson @kibanamachine
Throttle toast storms related to saving/restoring URL state (#154792)
dc1baa9 
## Summary

Resolves #153073.

Throttles toast errors related to restoring/saving URL state.

Before:

<img width="330" alt="image"
src="https://user-images.githubusercontent.com/1178348/231315783-98b966a8-b665-4465-91ae-b88933a56c3b.png">

After:

<img width="333" alt="image"
src="https://user-images.githubusercontent.com/1178348/231315724-7b3109eb-bdc7-405f-865f-36c909b907f4.png">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throttle toast storms related to saving/restoring URL state lukasolson/kibana
4 participants
@kertal @lukasolson @elasticmachine @davismcphee