-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttle KbnUrlStateStorage error messages #152983
Conversation
@Dosant this is still owned by @elastic/kibana-app-services, but I guess @elastic/appex-sharedux would be a better fit? |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Pinging @elastic/kibana-presentation (Team:Presentation) |
it's pretty strange GitHub is telling be to add impact & loe labels? and adding those doesn't unblock the PR??? |
I have seen that on a few of my PRs as well. |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kertal |
@nreese thx, now it seems to work ... merging |
Fix duplicate error messages caused by invalid URLs in Discover & Dashboard.
Summary
This PR throttles the error messages caused by invalid URLs in KbnUrlStateStorage. So e.g. in Discover & Dashboard an invalid url state caused duplicate error toasts:
With this PR, there's just one error.
In an upcoming PR, the URL state is requested more often initially in Discover, which leads to more toasts, and this was causing an functional test to fail. I researched and found a solution to fix this problem and decided to extract the solution to a separate PR
Testing
,
or)
)Checklist