Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guided onboarding] Change the API routes from /api to /internal #155611

Closed
yuliacech opened this issue Apr 24, 2023 · 0 comments · Fixed by #155643
Closed

[Guided onboarding] Change the API routes from /api to /internal #155611

yuliacech opened this issue Apr 24, 2023 · 0 comments · Fixed by #155643
Assignees
@yuliacech
Labels
Team:Journey/Onboarding Platform Journey Onboarding team

Comments

@yuliacech
Copy link
Contributor

Guided onboarding API endpoints are not intended for external use, only for the plugin's client side. To indicate that clearly in the routes, we need to change the API prefix from /api to /internal.

See a comment by @lukeelmers here
@yuliacech yuliacech added the Team:Journey/Onboarding Platform Journey Onboarding team label Apr 24, 2023
@yuliacech yuliacech mentioned this issue Apr 24, 2023
Merged
2 tasks
@yuliacech yuliacech self-assigned this Apr 24, 2023
@yuliacech yuliacech mentioned this issue Apr 24, 2023
Merged
yuliacech added a commit that referenced this issue Apr 25, 2023
@yuliacech @kibanamachine
[Guided onboarding] Change the API prefix to /internal (#155643)
13fd4f0 
## Summary

Fixes #155611
This PR changes the API prefix to indicate that the endpoints are
intended for internal use only. The plugin has been setup incorrectly
initially with the prefix `/api` that is intended for a public API.
There should not be any changes to the UI or functionality of the
plugin.


### Release Note
Fixed the guided onboarding API prefix to indicate that it's intended
for internal use

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuliacech yuliacech

Labels
Team:Journey/Onboarding Platform Journey Onboarding team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Guided onboarding] Change the API prefix to /internal yuliacech/kibana
1 participant
@yuliacech