Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided onboarding] Change the API prefix to /internal #155643

Merged

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Apr 24, 2023

Summary

Fixes #155611
This PR changes the API prefix to indicate that the endpoints are intended for internal use only. The plugin has been setup incorrectly initially with the prefix /api that is intended for a public API. There should not be any changes to the UI or functionality of the plugin.

Release Note

Fixed the guided onboarding API prefix to indicate that it's intended for internal use

@yuliacech yuliacech added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Journey/Onboarding Platform Journey Onboarding team labels Apr 24, 2023
@yuliacech yuliacech marked this pull request as ready for review April 24, 2023 16:41
@yuliacech yuliacech requested review from a team as code owners April 24, 2023 16:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Did not test locally. Thanks for fixing this!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 27.2KB 27.2KB +5.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 397 400 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 477 480 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech enabled auto-merge (squash) April 25, 2023 16:35
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuliacech yuliacech merged commit 13fd4f0 into elastic:main Apr 25, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 25, 2023
@yuliacech yuliacech deleted the guided_onboarding/8.8/change_api_prefix branch February 15, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:fix Team:Journey/Onboarding Platform Journey Onboarding team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Guided onboarding] Change the API routes from /api to /internal
6 participants