Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Should be able to open Discover when there is no data view #169873

Closed
thomasneirynck opened this issue Oct 25, 2023 · 8 comments
Closed

[Discover] Should be able to open Discover when there is no data view #169873

thomasneirynck opened this issue Oct 25, 2023 · 8 comments
Assignees
@Dosant @rshen91
Labels
Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@thomasneirynck
Copy link
Contributor

When there is no dataview, but there is data in Elasticsearch, users are presented with following screen in Discover

image

Now that ESQL has ad-hoc exploration, this screen should be re-imagined. e.g. by adding a link to ESQL-mode-Discover
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 25, 2023
@ThomThomson ThomThomson added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 26, 2023
@thomasneirynck thomasneirynck added the Feature:ES|QL ES|QL related features in Kibana label Oct 26, 2023
@kertal kertal added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Oct 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@afharo
Copy link
Member

afharo commented Nov 6, 2023

Whenever we address this, we should revert things like #170343 😇

@kertal
Copy link
Member

kertal commented Nov 7, 2023

This makes sense, but also this might have a bigger effort than it sounds ... if we allow users to navigate to Discover / ES|QL, they can create saved searches, also they can create visualizations on a dashboard. Dashboard also checks for existing data views, and so does Visualize Library ... I think those screens would be displayed even if there has already been a dashboard containing ES|QL been created.

@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Nov 9, 2023
@petrklapka
Copy link
Member

Discussed at triage - For quickest fix we recommend Discover team adds a button for "Explore in ES|QL" or something similar. SharedUX can assist if any changes are needed to the underlying component, but that should not be necessary.

@sixstringcode
Copy link

chatted with @ninoslavmiskovic about this earlier and he's asking if we can help them with some bandwidth to get this done.

@petrklapka
Copy link
Member

petrklapka commented Nov 14, 2023 •
edited
Loading

Thanks @sixstringcode , we didn't realize this was a bandwidth ask. Sure, we'll help. I added this back to our project and queued it up as hot on our Kanban board.

@rshen91 rshen91 self-assigned this Nov 14, 2023
@rshen91 rshen91 mentioned this issue Nov 15, 2023
Closed
8 tasks
@rshen91 rshen91 mentioned this issue Jan 4, 2024
Closed
9 tasks
@clintandrewhall clintandrewhall mentioned this issue Jan 5, 2024
Merged
5 tasks
@stratoula stratoula added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jan 30, 2024
Dosant added a commit that referenced this issue Feb 5, 2024
@clintandrewhall @stratoula
@rshen91 @Dosant
[ES|QL] Bypass no data views screen (#174316)
450f9f6 
> Derived from #173068
> Further addresses #169873

## Summary

- We're adding a link to the No Data Prompt to send a person to explore
their data using ES|QL if there exists any ingested data but no data
view.
- This PR populates the query bar with the first available index (some
special handling for logs index.
2a9edec)
- All consumers of the prompt/no data view are updated in this PR.
- [x] ~There's an issue where, if you're in Discover, clicking the link
won't refresh the page. .~ This is fixed on Discover side by
reinitializing the state container when user clicks the "try es|ql" link
and URL state updates.
- [x] ~There is an issue that you can save the es|ql chart from
Discover, but Dashboard's empty screen blocks the navigation because
data views don't exist
#174316 (comment).
This is fixed by allowing the dashboard to work without the default data
view. Hopefully, this won't lead to major issues
- [x] ~ES|QL panels can't be created without the default data views~
this is fixed by trying to fallback to an ad-hoc dataview, plan to move
that code to the utils introduced here
#174736
- [x] fix circular deps
- [x] Add functional tests


## Visuals



https://github.com/elastic/kibana/assets/7784120/af3592c1-f4c8-43bb-a128-3268b7761367




### Storybook Stories

#### Can access ES|QL

![Screenshot 2024-01-31 at 17 05
47](https://github.com/elastic/kibana/assets/7784120/370d0351-198e-4dc3-b22e-86f497ad4df5)


#### Cannot access (e.g. preview is unavailable - _not implemented_)

![Screenshot 2024-01-31 at 17 05
59](https://github.com/elastic/kibana/assets/7784120/c2bf52ab-9fa8-4f25-9e5d-512d4f4342fa)


---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Rachel Shen <rshen@elastic.co>
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
@Dosant Dosant closed this as completed Feb 5, 2024
@Dosant Dosant mentioned this issue Feb 6, 2024
Closed
@Dosant
Copy link
Contributor

Dosant commented Feb 6, 2024

A couple of follow-ups:

fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
@clintandrewhall @stratoula
@rshen91 @Dosant @fkanout
[ES|QL] Bypass no data views screen (elastic#174316)
1a3f195 
> Derived from elastic#173068
> Further addresses elastic#169873

## Summary

- We're adding a link to the No Data Prompt to send a person to explore
their data using ES|QL if there exists any ingested data but no data
view.
- This PR populates the query bar with the first available index (some
special handling for logs index.
elastic@2a9edec)
- All consumers of the prompt/no data view are updated in this PR.
- [x] ~There's an issue where, if you're in Discover, clicking the link
won't refresh the page. .~ This is fixed on Discover side by
reinitializing the state container when user clicks the "try es|ql" link
and URL state updates.
- [x] ~There is an issue that you can save the es|ql chart from
Discover, but Dashboard's empty screen blocks the navigation because
data views don't exist
elastic#174316 (comment).
This is fixed by allowing the dashboard to work without the default data
view. Hopefully, this won't lead to major issues
- [x] ~ES|QL panels can't be created without the default data views~
this is fixed by trying to fallback to an ad-hoc dataview, plan to move
that code to the utils introduced here
elastic#174736
- [x] fix circular deps
- [x] Add functional tests


## Visuals



https://github.com/elastic/kibana/assets/7784120/af3592c1-f4c8-43bb-a128-3268b7761367




### Storybook Stories

#### Can access ES|QL

![Screenshot 2024-01-31 at 17 05
47](https://github.com/elastic/kibana/assets/7784120/370d0351-198e-4dc3-b22e-86f497ad4df5)


#### Cannot access (e.g. preview is unavailable - _not implemented_)

![Screenshot 2024-01-31 at 17 05
59](https://github.com/elastic/kibana/assets/7784120/c2bf52ab-9fa8-4f25-9e5d-512d4f4342fa)


---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Rachel Shen <rshen@elastic.co>
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@clintandrewhall @stratoula
@rshen91 @Dosant @CoenWarmer
[ES|QL] Bypass no data views screen (elastic#174316)
4021c5d 
> Derived from elastic#173068
> Further addresses elastic#169873

## Summary

- We're adding a link to the No Data Prompt to send a person to explore
their data using ES|QL if there exists any ingested data but no data
view.
- This PR populates the query bar with the first available index (some
special handling for logs index.
elastic@2a9edec)
- All consumers of the prompt/no data view are updated in this PR.
- [x] ~There's an issue where, if you're in Discover, clicking the link
won't refresh the page. .~ This is fixed on Discover side by
reinitializing the state container when user clicks the "try es|ql" link
and URL state updates.
- [x] ~There is an issue that you can save the es|ql chart from
Discover, but Dashboard's empty screen blocks the navigation because
data views don't exist
elastic#174316 (comment).
This is fixed by allowing the dashboard to work without the default data
view. Hopefully, this won't lead to major issues
- [x] ~ES|QL panels can't be created without the default data views~
this is fixed by trying to fallback to an ad-hoc dataview, plan to move
that code to the utils introduced here
elastic#174736
- [x] fix circular deps
- [x] Add functional tests


## Visuals



https://github.com/elastic/kibana/assets/7784120/af3592c1-f4c8-43bb-a128-3268b7761367




### Storybook Stories

#### Can access ES|QL

![Screenshot 2024-01-31 at 17 05
47](https://github.com/elastic/kibana/assets/7784120/370d0351-198e-4dc3-b22e-86f497ad4df5)


#### Cannot access (e.g. preview is unavailable - _not implemented_)

![Screenshot 2024-01-31 at 17 05
59](https://github.com/elastic/kibana/assets/7784120/c2bf52ab-9fa8-4f25-9e5d-512d4f4342fa)


---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Rachel Shen <rshen@elastic.co>
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@clintandrewhall @stratoula
@rshen91 @Dosant @fkanout
[ES|QL] Bypass no data views screen (elastic#174316)
43f134f 
> Derived from elastic#173068
> Further addresses elastic#169873

## Summary

- We're adding a link to the No Data Prompt to send a person to explore
their data using ES|QL if there exists any ingested data but no data
view.
- This PR populates the query bar with the first available index (some
special handling for logs index.
elastic@2a9edec)
- All consumers of the prompt/no data view are updated in this PR.
- [x] ~There's an issue where, if you're in Discover, clicking the link
won't refresh the page. .~ This is fixed on Discover side by
reinitializing the state container when user clicks the "try es|ql" link
and URL state updates.
- [x] ~There is an issue that you can save the es|ql chart from
Discover, but Dashboard's empty screen blocks the navigation because
data views don't exist
elastic#174316 (comment).
This is fixed by allowing the dashboard to work without the default data
view. Hopefully, this won't lead to major issues
- [x] ~ES|QL panels can't be created without the default data views~
this is fixed by trying to fallback to an ad-hoc dataview, plan to move
that code to the utils introduced here
elastic#174736
- [x] fix circular deps
- [x] Add functional tests


## Visuals



https://github.com/elastic/kibana/assets/7784120/af3592c1-f4c8-43bb-a128-3268b7761367




### Storybook Stories

#### Can access ES|QL

![Screenshot 2024-01-31 at 17 05
47](https://github.com/elastic/kibana/assets/7784120/370d0351-198e-4dc3-b22e-86f497ad4df5)


#### Cannot access (e.g. preview is unavailable - _not implemented_)

![Screenshot 2024-01-31 at 17 05
59](https://github.com/elastic/kibana/assets/7784120/c2bf52ab-9fa8-4f25-9e5d-512d4f4342fa)


---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Rachel Shen <rshen@elastic.co>
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

@rshen91 rshen91

Labels
Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
10 participants
@kertal @thomasneirynck @afharo @Dosant @ThomThomson @elasticmachine @stratoula @rshen91 @petrklapka @sixstringcode