Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Present ES|QL as an equal to data views on the "no data views" screen #176291

Closed
Dosant opened this issue Feb 6, 2024 · 18 comments · Fixed by #194077
Closed

[ES|QL] Present ES|QL as an equal to data views on the "no data views" screen #176291

Dosant opened this issue Feb 6, 2024 · 18 comments · Fixed by #194077
Assignees
Labels
Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented Feb 6, 2024

Before ES|QL, it was impossible to use Discover/Dashboard without a data view, so we had an empty screen blocking the app until the user created a data view. With ES|QL we added a button to that empty screen to bypass data view creation. (#169873, #174316)

image

This is a major improvement, but this view still suggests data view as the main option and ES|QL as an alternative.

As was discussed in #171342 (comment), we should redesign that empty screen so that ES|QL is presented as an equivalent.

Per #174316 (comment), here are designs suggested by @andreadelrio: (Latest Figma Version)

image

image

Notes:
The illustration for the ES|QL card was found in a blog post. You can consider it a placeholder.
All copy needs to be reviewed by one of our UX writers.

cc @andreadelrio, @ryankeairns, @stratoula, @petrklapka

@Dosant Dosant added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:ES|QL ES|QL related features in Kibana labels Feb 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@petrklapka
Copy link
Member

Very good writeup @Dosant , thank you. I see you also added it to our "Tracking Epic" for ESQL flavored work. Gold star sir.
@stratoula and @Dosant - Is this reusable as a component? For two reasons: 1: If it is, we should own it. If it isn't it should be part of Discover App. 2: We'll need something like this for Dashboards too no? Maybe other apps too? So can there be a reusable component derived from this?

@Dosant
Copy link
Contributor Author

Dosant commented Feb 6, 2024

Is this reusable as a component? For two reasons: 1: If it is, we should own it. If it isn't it should be part of Discover App. 2: We'll need something like this for Dashboards too no? Maybe other apps too? So can there be a reusable component derived from this?

This would be a change to an existing reusable component (empty states) that we currently own and the component is currently used at least in Discover, Dashboard, Visualization Editors

@stratoula
Copy link
Contributor

Is this reusable as a component?

I think it is yes, we need to reuse it for now:

  • Discover
  • Dashboards (navigate to a dashboard). The @elastic/kibana-presentation team has already an issue tracking some enhancements
  • Later in Lens when we support ES|QL
  • Other usages in other applications who depend on dataviews now but are thinking on supporting ES|QL

@petrklapka
Copy link
Member

@osmanis and @kevinsweet - Where else in the product will we need to make this kind of "switch" decision due to ESQL's ability to work without DataViews? Are the solutions affected? Is there an opportunity for a platform level component here?

@Dosant Dosant removed their assignment Feb 8, 2024
@kertal kertal removed the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Feb 15, 2024
@stratoula stratoula added the Team:ESQL ES|QL related features in Kibana label Mar 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@petrklapka
Copy link
Member

@andreadelrio - I'm putting this up as a candidate for planned Q1FY25 work. The screencaps we have in the issue description are good, but can you please link the figma/whimsical being used to maintain the "latest" design for this?

@andreadelrio
Copy link
Contributor

@andreadelrio - I'm putting this up as a candidate for planned Q1FY25 work. The screencaps we have in the issue description are good, but can you please link the figma/whimsical being used to maintain the "latest" design for this?

@petrklapka Sure thing! Here you go.

@stratoula
Copy link
Contributor

@petrklapka is this going to be priortiized soonish?

@petrklapka
Copy link
Member

Hey @stratoula - we punted on this for FY25Q1 because we put a lot of resources into dashboards, and leant out some engineering hours to help AX and Cloud teams. I was hoping to pick it up even though it wasn't on our Q1 roadmap, but we're 1 month into the quarter now and quite busy since we lost Vadim, so I've put this as a "Next Quarter Candidate".

@petrklapka
Copy link
Member

@andreadelrio - Hello! This is in the queue, and Anton will most likely engage on it by middle of September. Just wanted to give you a heads up, in case you wanted to revisit/refresh the designs before then!

@petrklapka petrklapka assigned tsullivan and unassigned Dosant Sep 19, 2024
@tsullivan
Copy link
Member

tsullivan commented Sep 25, 2024

@andreadelrio I'm picking up this task.

Question: What if the user does not have permission to create a data view? This is what that scenario looks like currently:
Image

Edit: if the user does not have permission to create a data view, I assume it will work OK to use the existing text and not show the button:
Image

@ryankeairns
Copy link
Contributor

@tsullivan to clarify, does that last image show if you have data but no data views?

@tsullivan
Copy link
Member

@ryankeairns yes, the last image I shared would be the design users see if they

  1. Have data
  2. Have no data views
  3. Do not have privilege to create a data view

@tsullivan
Copy link
Member

PR is ready for review. cc @andreadelrio @ryankeairns Can we make sure the design uses finalized content?

@ryankeairns
Copy link
Contributor

PR is ready for review. cc @andreadelrio @ryankeairns Can we make sure the design uses finalized content?

@florent-leborgne It's been a while... do you recall reviewing or providing copy for this empty prompt? In either case, does it look ok to merge?
cc:/ @andreadelrio

@stratoula
Copy link
Contributor

stratoula commented Oct 9, 2024

@ryankeairns just fyi I have already pinged @leemthompo in the PR and has helped us with the texts.

tsullivan added a commit that referenced this issue Oct 9, 2024
…" screen (#194077)

## Summary

Resolves #176291

### Screenshots

#### Discover/Dashboard/Visualize
<img width="1517" alt="image"
src="https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3">

#### Stack Management > Data view
<img width="1519" alt="image"
src="https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3">

#### If User does not have privilege to create a Data View
<img width="1336" alt="image"
src="https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Use a new SVG resource for the ES|QL illustration
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 9, 2024
…" screen (elastic#194077)

## Summary

Resolves elastic#176291

### Screenshots

#### Discover/Dashboard/Visualize
<img width="1517" alt="image"
src="https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3">

#### Stack Management > Data view
<img width="1519" alt="image"
src="https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3">

#### If User does not have privilege to create a Data View
<img width="1336" alt="image"
src="https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Use a new SVG resource for the ES|QL illustration
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
(cherry picked from commit 56e1e68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants