Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTR] Use importExport for saved_object/basic archive #100244

Merged
merged 5 commits into from
Jun 1, 2021
Merged

[FTR] Use importExport for saved_object/basic archive #100244

merged 5 commits into from
Jun 1, 2021

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented May 17, 2021 •
edited
Loading

Required to sanely backport #99980 as the updated esArchive includes migrations.

Migrated esArchives to kbnArchives and used spaces when isolation was required.

@tylersmalley tylersmalley force-pushed the ftr-so-basic branch 8 times, most recently from 1993bb5 to 5d9de41 Compare May 24, 2021 14:22
@tylersmalley tylersmalley force-pushed the ftr-so-basic branch 4 times, most recently from 01508a5 to 6cfa026 Compare May 26, 2021 17:14
@LeeDr
Copy link

LeeDr commented May 26, 2021

Required to sanely backport #99980 as the updated esArchive includes migrations.

I don't understand. The json saved object files will also have a problem backporting, unless you create them from an older version?

@tylersmalley
Copy link
Contributor Author

@LeeDr export archives don't contain mappings and index aliases, which are the issue.

@tylersmalley tylersmalley marked this pull request as ready for review May 26, 2021 23:38
@tylersmalley tylersmalley requested a review from a team as a code owner May 26, 2021 23:38
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0 labels May 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label May 27, 2021
@tylersmalley tylersmalley enabled auto-merge (squash) May 27, 2021 00:15
@tylersmalley tylersmalley disabled auto-merge May 27, 2021 00:34
spalger
spalger approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that we didn't implicitly create the space when you try to import into a space that doesn't exist, but if you disagree I'm fine keeping it.

Test verified to be pretty much copies of the existing tests. LGTM!

src/dev/precommit_hook/casing_check_config.js Outdated Show resolved Hide resolved
test/api_integration/apis/saved_objects/bulk_create.ts Outdated Show resolved Hide resolved
Tyler Smalley added 2 commits June 1, 2021 07:03
[FTR] Use importExport for saved_object/basic archive
cd7ce3d 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Update suggestions tests
ef06a34 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 2, 2021
@jloleysens
Merge branch 'reporting/new-png-pdf-report-type' of github.com:jloley…
f34d980 
…sens/kibana into reporting/new-png-pdf-report-type

* 'reporting/new-png-pdf-report-type' of github.com:jloleysens/kibana: (46 commits)
  [Security Solution] Add Ransomware canary advanced policy option (elastic#101068)
  [Exploratory view] Core web vitals (elastic#100320)
  [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034)
  [Lens] Use a setter function for the dimension panel (elastic#101123)
  [Index Patterns] Fix return saved index pattern object (elastic#101051)
  [CI] For PRs, build TS refs before public api docs check (elastic#100791)
  [Maps] fix line and polygon label regression (elastic#101085)
  Migrate CCR to new ES JS client. (elastic#100131)
  [Canvas] Switch Canvas to use React Router (elastic#100579)
  [Expressions] Use table column ID instead of name when set (elastic#99724)
  [DOCS] Updates docs landing page (elastic#100749)
  [DOCS] Corrects typo in step 3 (elastic#101079)
  [DOCS] Updates runtime example in Discover (elastic#100926)
  Migrate kibana.autocomplete config to data plugin (elastic#100586)
  [Uptime] New width/delay definition for waterfall sidebar item tooltip (elastic#100147)
  [FTR] Use importExport for saved_object/basic archive (elastic#100244)
  [Fleet] Better input for multi text input in agent policy builder (elastic#101020)
  [CI] Buildkite support with Baseline pipeline (elastic#100492)
  [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (elastic#100388)
  Create API keys with metadata (elastic#100682)
  ...
tylersmalley added a commit that referenced this pull request Jun 2, 2021
@tylersmalley
Revert "[FTR] Use importExport for saved_object/basic archive (#100244)"
2956993 
This reverts commit 0f9debe.
@tylersmalley tylersmalley mentioned this pull request Jun 2, 2021
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 3, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@tylersmalley tylersmalley mentioned this pull request Jun 9, 2021
Closed
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jun 9, 2021
[FTR] Use importExport for saved_object/basic archive (elastic#100244)
bcf3698 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jun 12, 2021
[FTR] Use importExport for saved_object/basic archive (elastic#100244)
23c79e0 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jun 12, 2021
[7.x] [FTR][CI] Use default distribution for all tests (#94968) (#101118
73225da 
)

* [FTR][CI] Use default distribution for all tests (#94968)
* [FTR] Use importExport for saved_object/basic archive (#100244)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added the backport:skip This commit does not require backporting label Jun 12, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 12, 2021
@tylersmalley
Copy link
Contributor Author

backport: #101118

@tylersmalley tylersmalley mentioned this pull request Jun 13, 2021
Merged
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jun 13, 2021
[FTR] Use importExport for saved_object/basic archive (elastic#100244)
dfa1e94 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jun 13, 2021
[FTR] Use importExport for saved_object/basic archive (#100244) (#102016
9851b7b 
)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jun 14, 2021
Revert "[FTR] Use importExport for saved_object/basic archive (elasti…
5b6c918 
…c#100244) (elastic#102016)"

This reverts commit 9851b7b.
tylersmalley pushed a commit that referenced this pull request Jun 14, 2021
Revert: [7.x] [FTR][CI] Use default distribution for all tests (#102019)
c272bdb 
* Revert "[FTR] Use importExport for saved_object/basic archive (#100244) (#102016)"

This reverts commit 9851b7b.

* Revert "[7.x] [FTR][CI] Use default distribution for all tests (#94968) (#101118)"

This reverts commit 73225da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tylersmalley @LeeDr @elasticmachine @kibanamachine @spalger @jbudz