Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Buildkite support with Baseline pipeline #100492

Merged
merged 27 commits into from
Jun 1, 2021
Merged

[CI] Buildkite support with Baseline pipeline #100492

merged 27 commits into from
Jun 1, 2021

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented May 24, 2021 •
edited
Loading

Part of #95717

This is the first Buildkite PR, and adds support for the Baseline pipeline, and general things needed to run our scripts/jobs in Buildkite.

You can see this pipeline running here: https://buildkite.com/elastic/kibana-on-merge/builds?branch=buildkite-baseline

I've renamed "Baseline" to "On Merge" to make it more obvious that this pipeline runs for each commit of Kibana, i.e. each time a PR is merged. Also, this pipeline used to be primarily for generating baseline CI metrics, but it's now doing other things as well.

I've removed most non-Baseline Buildkite code for this PR, so that it mostly contains foundations + Baseline CI. There are a few things mostly related to other jobs (e.g. certain env var switches, or the es snapshot manifest annotation), but they're small and leaving them in here will help me not lose track of them.

I would also recommend checking out the .buildkite directory outside of the PR UI, as it's easier to see and understand the directory structure.

Once merged, we can:

  • Set buildkite-agent-manager to look at master for buildkite agent configs, instead of the buildkite branch
  • Set the On Merge pipeline to build every commit of master
  • Let the On Merge pipeline run side-by-side with Jenkins and sort out any issues that come up

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v8.0.0 Team:Operations Team label for Operations Team labels May 24, 2021
@brianseeders
Copy link
Contributor Author

@elasticmachine merge upstream

@brianseeders brianseeders marked this pull request as ready for review May 27, 2021 16:20
@brianseeders brianseeders requested a review from a team as a code owner May 27, 2021 16:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@brianseeders
Copy link
Contributor Author

@elasticmachine merge upstream

spalger
spalger approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, and only skimmed most of the shell, but since this is low risk I'm good merging and seeing how it goes. LGTM

packages/kbn-test/src/functional_tests/tasks.js Outdated Show resolved Hide resolved
packages/kbn-test/src/functional_test_runner/functional_test_runner.ts Outdated Show resolved Hide resolved
@brianseeders
Apply suggestions from code review
b102e10 
Co-authored-by: Spencer <email@spalger.com>
tylersmalley
tylersmalley reviewed Jun 1, 2021
View reviewed changes
.buildkite/agents.json
"queue": "default",
"name": "kb-default",
"minimumAgents": 1,
"maximumAgents": 100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a max here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously not a blocker to this PR since we're just talking baseline jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like putting limits in just so that something doesn't accidentally spin up agents out of control somehow, and they are easy to adjust. These default agents typically only run really short/quick steps, so I'm guessing the number of these would actually stay under 10 or so most of the time

@brianseeders
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
infra 256 146 -110
lens 67 45 -22
ml 121 115 -6
total -138

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit 54c3ca1 into master Jun 1, 2021
@brianseeders brianseeders deleted the buildkite-baseline branch June 1, 2021 17:11
@brianseeders brianseeders mentioned this pull request Jun 1, 2021
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jun 1, 2021
@brianseeders
[CI] Buildkite support with Baseline pipeline (elastic#100492)
d7944ff 
# Conflicts:
#	.github/CODEOWNERS
@brianseeders brianseeders mentioned this pull request Jun 1, 2021
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jun 1, 2021
@brianseeders
[CI] Buildkite support with Baseline pipeline (elastic#100492)
7cfb11d 
# Conflicts:
#	.github/CODEOWNERS
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 2, 2021
@jloleysens
Merge branch 'reporting/new-png-pdf-report-type' of github.com:jloley…
f34d980 
…sens/kibana into reporting/new-png-pdf-report-type

* 'reporting/new-png-pdf-report-type' of github.com:jloleysens/kibana: (46 commits)
  [Security Solution] Add Ransomware canary advanced policy option (elastic#101068)
  [Exploratory view] Core web vitals (elastic#100320)
  [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034)
  [Lens] Use a setter function for the dimension panel (elastic#101123)
  [Index Patterns] Fix return saved index pattern object (elastic#101051)
  [CI] For PRs, build TS refs before public api docs check (elastic#100791)
  [Maps] fix line and polygon label regression (elastic#101085)
  Migrate CCR to new ES JS client. (elastic#100131)
  [Canvas] Switch Canvas to use React Router (elastic#100579)
  [Expressions] Use table column ID instead of name when set (elastic#99724)
  [DOCS] Updates docs landing page (elastic#100749)
  [DOCS] Corrects typo in step 3 (elastic#101079)
  [DOCS] Updates runtime example in Discover (elastic#100926)
  Migrate kibana.autocomplete config to data plugin (elastic#100586)
  [Uptime] New width/delay definition for waterfall sidebar item tooltip (elastic#100147)
  [FTR] Use importExport for saved_object/basic archive (elastic#100244)
  [Fleet] Better input for multi text input in agent policy builder (elastic#101020)
  [CI] Buildkite support with Baseline pipeline (elastic#100492)
  [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (elastic#100388)
  Create API keys with metadata (elastic#100682)
  ...
brianseeders added a commit that referenced this pull request Jun 3, 2021
@brianseeders
[CI] Buildkite support with Baseline pipeline (#100492) (#101108)
95eff5c
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 3, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 4, 2021
brianseeders added a commit that referenced this pull request Jun 4, 2021
@brianseeders
[CI] Buildkite support with Baseline pipeline (#100492) (#101109)
4e0f400
@spalger spalger mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@spalger spalger spalger approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brianseeders @elasticmachine @kibanamachine @tylersmalley @spalger @jbudz