Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds dimensionName to datatable column meta information #106514

Merged
merged 10 commits into from
Jul 29, 2021
Merged

adds dimensionName to datatable column meta information #106514

merged 10 commits into from
Jul 29, 2021

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jul 22, 2021 •
edited
Loading

Summary

resolves #78277

Checklist

Delete any items that are not applicable to this PR.

@ppisljar ppisljar requested a review from a team July 22, 2021 10:17
@ppisljar ppisljar requested a review from a team as a code owner July 22, 2021 10:17
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jul 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@dej611 dej611 mentioned this pull request Jul 22, 2021
Merged
30 tasks
@ppisljar ppisljar added the release_note:skip Skip the PR/issue when compiling release notes label Jul 26, 2021
stratoula
stratoula approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM in case of green CI.
Thanx for also adding tests Peter :)

@dej611 dej611 mentioned this pull request Jul 26, 2021
Closed
@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

ppisljar and others added 2 commits July 29, 2021 08:52
dokmic
dokmic approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 104 106 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypePie 20.2KB 20.8KB +610.0B
visualizations 55.4KB 57.9KB +2.4KB
total +3.0KB
Unknown metric groups

API count

id before after diff
expressions 2003 2004 +1
visualizations 247 257 +10
total +11

API count missing comments

id before after diff
visualizations 229 239 +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 29, 2021
@ppisljar ppisljar merged commit 0ad10e8 into elastic:master Jul 29, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2021
@ppisljar @kibanamachine
adds dimensionName to datatable column meta information (elastic#106514)
5b7a5b8
@kibanamachine kibanamachine mentioned this pull request Jul 29, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 29, 2021
@kibanamachine @ppisljar
adds dimensionName to datatable column meta information (#106514) (#1…
357aff7 
…07174)

Co-authored-by: Peter Pisljar <peter.pisljar@gmail.com>
@stratoula stratoula mentioned this pull request Jul 30, 2021
Merged
2 tasks
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@ppisljar @vadimkibana
adds dimensionName to datatable column meta information (elastic#106514)
389e163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@dokmic dokmic dokmic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[expressions] inspector alerting adapter
5 participants
@ppisljar @elasticmachine @kibanamachine @dokmic @stratoula