[Visualizations] Adds dimensionName in datatable meta info #107265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
Feature:Vislib
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
added
Feature:ExpressionLanguage
dej611
reviewed
Jul 30, 2021
Comment on lines
+20
to
+38
| export interface DateHistogramParams { | ||
| date: boolean; | ||
| interval: number; | ||
| intervalESValue: number; | ||
| intervalESUnit: string; | ||
| format: string; | ||
| bounds?: { | ||
| min: string | number; | ||
| max: string | number; | ||
| }; | ||
| } | ||
|
|
||
| export interface HistogramParams { | ||
| interval: number; | ||
| } | ||
|
|
||
| export interface FakeParams { | ||
| defaultValue: string; | ||
| } |
There was a problem hiding this comment.
Is this a duplicate of the vis_type_xy/public/types content?
In case can we rely on these only without duplication? If you reexport these from the param.ts file the impact on other files should be minimal.
There was a problem hiding this comment.
I forgot them, thanx. I moved them to the visualizations plugin, otherwise we will have circular dependencies
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
Non-exported public API item count
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Aug 3, 2021
…07265) * [Visualizations] Adds dimensionName in datatable meta info * Delete unused file * fix i18n * Another fix of i18n * Fix translations * Remove double types * Fix types * Another type fix Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Aug 3, 2021
…107501) * [Visualizations] Adds dimensionName in datatable meta info * Delete unused file * fix i18n * Another fix of i18n * Fix translations * Remove double types * Fix types * Another type fix Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…07265) * [Visualizations] Adds dimensionName in datatable meta info * Delete unused file * fix i18n * Another fix of i18n * Fix translations * Remove double types * Fix types * Another type fix Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follup PR of #106514
Adds dimensionName in datatable meta information for the rest legacy visualizations (it has only been implemented for pie chart).
Checklist
Delete any items that are not applicable to this PR.