Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all instances of EuiKeyboardAccessible #106910

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Remove all instances of EuiKeyboardAccessible #106910

merged 3 commits into from
Jul 28, 2021

Conversation

myasonik
Copy link
Contributor

Summary

This PR removes all instances of EuiKeyboardAccessible which was deprecated in EUI in Oct of 2020 (elastic/eui#4135). It is now slated for immediate removal.

Help!

I don't know your apps. I don't even know where these instances get rendered. If you own one of these instances of EuiKeyboardAccessible, please test (and fix) as necessary.

I'm hoping my work here is a jumping off point to finish off this removal effort.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@myasonik myasonik added technical debt Improvement of the software architecture and operational architecture v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 27, 2021
@myasonik myasonik requested a review from a team July 27, 2021 20:17
@myasonik myasonik requested a review from a team as a code owner July 27, 2021 20:17
@myasonik myasonik requested a review from a team July 27, 2021 20:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@myasonik
Copy link
Contributor Author

@elastic/kibana-app @elastic/security-solution @elastic/stack-monitoring-ui

Y'all were identified as the owners for these instances! Please see the Help section in the PR description for how I'm hoping we can make progress on this effort.

Thanks!

stratoula
stratoula approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Graph and metric Viz work fine. There is only one test failing that is easy to be fixed.
I am approving it, no need to review it again, LGTM

src/plugins/vis_type_metric/public/components/metric_vis_value.test.tsx Show resolved Hide resolved
x-pack/plugins/graph/public/components/field_manager/field_editor.tsx Show resolved Hide resolved
@myasonik
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 1.1MB 1.1MB -195.0B
monitoring 730.2KB 730.0KB -244.0B
visTypeMetric 17.0KB 16.2KB -796.0B
total -1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

FrankHassanabad
FrankHassanabad approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

What I did:

  • Looked at the line and verified it is only a comment removal

@myasonik myasonik merged commit 28fcd59 into elastic:master Jul 28, 2021
@myasonik myasonik deleted the remove-euikeyboardaccessible branch July 28, 2021 21:19
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 28, 2021
@kibanamachine
Remove all instances of EuiKeyboardAccessible (elastic#106910)
b1a0d36 
* remove all instances of EuiKeyboardAccessible
@kibanamachine kibanamachine mentioned this pull request Jul 28, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 28, 2021
@kibanamachine
Remove all instances of EuiKeyboardAccessible (#106910) (#107095)
cbdacde 
* remove all instances of EuiKeyboardAccessible

Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@vadimkibana
Remove all instances of EuiKeyboardAccessible (elastic#106910)
cca2437 
* remove all instances of EuiKeyboardAccessible
@thompsongl thompsongl mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@neptunian neptunian neptunian approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed EUI release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@myasonik @elasticmachine @kibanamachine @FrankHassanabad @neptunian @stratoula