Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] 'index patter' -> 'data view' in user facing copy #110701

Merged
merged 4 commits into from
Sep 1, 2021
Merged

[Maps] 'index patter' -> 'data view' in user facing copy #110701

merged 4 commits into from
Sep 1, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 31, 2021 •
edited
Loading

Closes #109307

Update index pattern copy in

  • maps plugin
  • file_upload plugin
  • Maps documentation

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 31, 2021
@nreese nreese requested a review from thomasneirynck August 31, 2021 18:47
@nreese nreese requested a review from a team as a code owner August 31, 2021 18:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese changed the title [Maps] replace index pattern with data view in user facing copy [Maps] 'index patter' -> 'data view' in user facing copy Aug 31, 2021
thomasneirynck
thomasneirynck approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx !

Should we update as well

kibana/x-pack/plugins/maps/public/classes/layers/file_upload_wizard/config.tsx

Line 21 in f972174

'Unable to upload files, you are missing the Kibana privilege "Index Pattern Management".',
?

'Unable to upload files, you are missing the Kibana privilege "Data View Management".

since this role would likely get renamed too

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 36d0b76 into elastic:index_patterns_to_data_views_user_content_feature_branch Sep 1, 2021
This was referenced Sep 1, 2021
Closed
Closed
@peteharverson peteharverson mentioned this pull request Sep 16, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck