Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search sessions] Don't show incomplete warning if search requests aren't in session #112364

Merged
merged 6 commits into from
Sep 22, 2021

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Sep 15, 2021

Summary

Partially addresses #106074.

Prior to this PR, if you restored a search session, and any search requests were made outside of the scope of the restored session, you'd still get the following warning:

Screen Shot 2021-07-19 at 12 18 09

This can be easily reproduced by adding an input control to a dashboard, which makes a search request to get the list of options (or the min/max of a range, if using a range slider).

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Release note

When restoring a search session, the "your search is still running" popup will no longer be shown for incomplete search requests outside of the scope of the search session.

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana release_note:fix v8.0.0 Team:AppServices auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v7.15.1 Feature:Search Sessions labels Sep 15, 2021
@lukasolson lukasolson requested a review from Dosant September 15, 2021 22:35
@lukasolson lukasolson self-assigned this Sep 15, 2021
@lukasolson lukasolson requested a review from a team as a code owner September 15, 2021 22:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

…ceptor.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
@lukasolson lukasolson requested a review from Dosant September 20, 2021 17:27
@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 492.2KB 492.2KB +10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit f4c2a93 into elastic:master Sep 22, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2021
…en't in session (elastic#112364)

* [Search sessions] Don't show incomplete warning if search requests aren't in session"

* Update src/plugins/data/public/search/search_interceptor/search_interceptor.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Fix lint

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2021
…en't in session (elastic#112364)

* [Search sessions] Don't show incomplete warning if search requests aren't in session"

* Update src/plugins/data/public/search/search_interceptor/search_interceptor.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Fix lint

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x
7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 22, 2021
…en't in session (#112364) (#112893)

* [Search sessions] Don't show incomplete warning if search requests aren't in session"

* Update src/plugins/data/public/search/search_interceptor/search_interceptor.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Fix lint

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
kibanamachine added a commit that referenced this pull request Sep 23, 2021
…en't in session (#112364) (#112892)

* [Search sessions] Don't show incomplete warning if search requests aren't in session"

* Update src/plugins/data/public/search/search_interceptor/search_interceptor.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Fix lint

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 23, 2021
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (189 commits)
  fix permissions for cloud test (elastic#112568)
  Updates the VEGA docs for v8.0 (elastic#112781)
  Updates the TSVB docs for v8 (elastic#112778)
  [Expressions] Fix setup and start contracts (elastic#110841)
  [DOCS] Update remote cluster and security links (elastic#112874)
  test/functional/apps/management/_test_huge_fields.js (elastic#112878)
  Fix the other one... (elastic#112873)
  [data.search.aggs] Use fields instead of _source in top_hits agg (elastic#109531)
  [Search sessions] Don't show incomplete warning if search requests aren't in session (elastic#112364)
  [data.search] Do not send ignore_throttled when search:includeFrozen is disabled (elastic#112755)
  [Monitoring] Add KQL filter bar to alerts (elastic#111663)
  Log deprecation warnings for plugins which won't be disable-able in 8.0 (elastic#112602)
  [CI] Balance CI Groups (elastic#112836)
  Add ILM URLs to documentation link service (elastic#112748)
  Bump chromedriver to 93 (elastic#112847)
  [Maps] move joins from LayerDescriptor to VectorLayerDescriptor (elastic#112427)
  Add a handler for a possible promise rejection (elastic#112840)
  Removes space, fix build (elastic#112856)
  [Maps] fix unhandled promise rejections in jest tests (elastic#112712)
  Copy pass 3 (elastic#112815)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/dashboard_app.tsx
#	src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Search Sessions Feature:Search Querying infrastructure in Kibana release_note:fix v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants