Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pass 3 #112815

Merged
merged 5 commits into from
Sep 22, 2021
Merged

Copy pass 3 #112815

merged 5 commits into from
Sep 22, 2021

Conversation

yakhinvadim
Copy link
Contributor

@yakhinvadim yakhinvadim commented Sep 22, 2021

Summary

This is a small copy update after the discussion in https://github.com/elastic/workplace-search-team/issues/1935

Before After
Screen Shot 2021-09-22 at 9 31 32 AM Screen Shot 2021-09-22 at 9 29 36 AM

Checklist

Closes https://github.com/elastic/workplace-search-team/issues/1935

@yakhinvadim yakhinvadim added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 22, 2021
@yakhinvadim yakhinvadim marked this pull request as ready for review September 22, 2021 12:35
@yakhinvadim yakhinvadim requested a review from a team September 22, 2021 12:35
@yakhinvadim
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yakhinvadim
Copy link
Contributor Author

@elasticmachine merge upstream

@yakhinvadim yakhinvadim enabled auto-merge (squash) September 22, 2021 14:18
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/search/session·ts.apis search search session touched time updates when you poll on an search

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]                 │
[00:00:00]                   └-: apis
[00:00:00]                     └-> "before all" hook in "apis"
[00:00:00]                     └-: search
[00:00:00]                       └-> "before all" hook in "search"
[00:00:06]                       └-: search session
[00:00:06]                         └-> "before all" hook for "should fail to extend a nonexistent session"
[00:00:06]                         └-> should fail to extend a nonexistent session
[00:00:06]                           └-> "before each" hook: global before each for "should fail to extend a nonexistent session"
[00:00:06]                           │ proc [kibana]   log   [14:58:05.651] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:06]                           │ proc [kibana]   statusCode: 404,
[00:00:06]                           │ proc [kibana]   error: 'Not Found',
[00:00:06]                           │ proc [kibana]   message: 'Saved object [search-session/123] not found'
[00:00:06]                           │ proc [kibana] }
[00:00:06]                           └- ✓ pass  (106ms) "apis search search session should fail to extend a nonexistent session"
[00:00:06]                         └-> should sync search ids into not persisted session
[00:00:06]                           └-> "before each" hook: global before each for "should sync search ids into not persisted session"
[00:00:06]                           │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:06]                           │ proc [kibana]   log   [14:58:05.854] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:06]                           │ proc [kibana]   statusCode: 404,
[00:00:06]                           │ proc [kibana]   error: 'Not Found',
[00:00:06]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.795996671540419] not found'
[00:00:06]                           │ proc [kibana] }
[00:00:06]                           │ debg --- retry.waitForWithTimeout error: expected 200 "OK", got 404 "Not Found"
[00:00:07]                           │ proc [kibana]   log   [14:58:06.449] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:07]                           │ proc [kibana]   statusCode: 404,
[00:00:07]                           │ proc [kibana]   error: 'Not Found',
[00:00:07]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.795996671540419] not found'
[00:00:07]                           │ proc [kibana] }
[00:00:07]                           │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:00:07]                           │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/9WtAtNkxSwOSszE7KmTnnQ] update_mapping [_doc]
[00:00:07]                           └- ✓ pass  (1.3s) "apis search search session should sync search ids into not persisted session"
[00:00:07]                         └-> should complete session when searches complete
[00:00:07]                           └-> "before each" hook: global before each for "should complete session when searches complete"
[00:00:08]                           │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:08]                           │ debg --- retry.waitForWithTimeout error: expected [] to contain 'FlBwWGNhTExaUjRDQ2tMeVdkX3J5a1EbSkpEd3RkdExRaUc0M3R5SmNyUkZrZzoyNTQx'
[00:00:19]                           │ debg Waiting up to 5000ms for searches eventually complete and session gets into the complete state...
[00:00:19]                           └- ✓ pass  (11.6s) "apis search search session should complete session when searches complete"
[00:00:19]                         └-> touched time updates when you poll on an search
[00:00:19]                           └-> "before each" hook: global before each for "touched time updates when you poll on an search"
[00:00:19]                           │ debg Waiting up to 20000ms for search session created...
[00:00:19]                           │ proc [kibana]   log   [14:58:18.713] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:19]                           │ proc [kibana]   statusCode: 404,
[00:00:19]                           │ proc [kibana]   error: 'Not Found',
[00:00:19]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.8522549834475832] not found'
[00:00:19]                           │ proc [kibana] }
[00:00:20]                           │ proc [kibana]   log   [14:58:19.293] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:20]                           │ proc [kibana]   statusCode: 404,
[00:00:20]                           │ proc [kibana]   error: 'Not Found',
[00:00:20]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.8522549834475832] not found'
[00:00:20]                           │ proc [kibana] }
[00:00:23]                           └- ✖ fail: apis search search session touched time updates when you poll on an search
[00:00:23]                           │      Error: expected '2021-09-22T14:58:19.689Z' to be below 2021-09-22T14:58:19.689Z
[00:00:23]                           │       at Assertion.assert (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:00:23]                           │       at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:336:8)
[00:00:23]                           │       at Function.lessThan (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:531:15)
[00:00:23]                           │       at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
[00:00:23]                           │       at runMicrotasks (<anonymous>)
[00:00:23]                           │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:00:23]                           │       at Object.apply (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:00:23]                           │ 
[00:00:23]                           │ 

Stack Trace

Error: expected '2021-09-22T14:58:19.689Z' to be below 2021-09-22T14:58:19.689Z
    at Assertion.assert (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:336:8)
    at Function.lessThan (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:531:15)
    at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB -188.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yakhinvadim yakhinvadim merged commit 23c8299 into elastic:master Sep 22, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2021
* Remove Source config section description

* Update copy

* Update i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 22, 2021
* Remove Source config section description

* Update copy

* Update i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 23, 2021
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (189 commits)
  fix permissions for cloud test (elastic#112568)
  Updates the VEGA docs for v8.0 (elastic#112781)
  Updates the TSVB docs for v8 (elastic#112778)
  [Expressions] Fix setup and start contracts (elastic#110841)
  [DOCS] Update remote cluster and security links (elastic#112874)
  test/functional/apps/management/_test_huge_fields.js (elastic#112878)
  Fix the other one... (elastic#112873)
  [data.search.aggs] Use fields instead of _source in top_hits agg (elastic#109531)
  [Search sessions] Don't show incomplete warning if search requests aren't in session (elastic#112364)
  [data.search] Do not send ignore_throttled when search:includeFrozen is disabled (elastic#112755)
  [Monitoring] Add KQL filter bar to alerts (elastic#111663)
  Log deprecation warnings for plugins which won't be disable-able in 8.0 (elastic#112602)
  [CI] Balance CI Groups (elastic#112836)
  Add ILM URLs to documentation link service (elastic#112748)
  Bump chromedriver to 93 (elastic#112847)
  [Maps] move joins from LayerDescriptor to VectorLayerDescriptor (elastic#112427)
  Add a handler for a possible promise rejection (elastic#112840)
  Removes space, fix build (elastic#112856)
  [Maps] fix unhandled promise rejections in jest tests (elastic#112712)
  Copy pass 3 (elastic#112815)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/dashboard_app.tsx
#	src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants