Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Convert ScriptedFieldsTable and SourceFiltersTable to UI Framework components. (#11401) #11454

Merged
merged 2 commits into from
Apr 27, 2017
Merged

[5.x] Convert ScriptedFieldsTable and SourceFiltersTable to UI Framework components. (#11401) #11454

merged 2 commits into from
Apr 27, 2017

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Apr 26, 2017 •
edited
Loading

Backports #11401 and makes updates to the warning introduced by #9193

Before

image

After

image

@Bargs Bargs self-requested a review April 26, 2017 21:35
@Bargs
Copy link
Contributor

Bargs commented Apr 27, 2017

Failure:

        └- ✖ fail: "dashboard app dashboard view edit mode shows lose changes warning and loses changes on confirmation when a filter is deleted"
         │        tryForTime timeout: Error: expected filters
         │           at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/apps/dashboard/_view_edit.js:179:40
         │           at undefined.next (native)
         │           at step (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/apps/dashboard/_view_edit.js:1:1)
         │           at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/apps/dashboard/_view_edit.js:1:1
         │           at process._tickDomainCallback (internal/process/next_tick.js:135:7)
         │         Error: tryForTime timeout: Error: expected filters
         │         at test/functional/apps/dashboard/_view_edit.js:179:40
         │         at undefined.next (native)
         │         at step (test/functional/apps/dashboard/_view_edit.js:1:1)
         │         at test/functional/apps/dashboard/_view_edit.js:1:1
         │         at process._tickDomainCallback (internal/process/next_tick.js:135:7)
         │         at attempt (test/functional/services/retry.js:19:17)
         │         at tryCatcher (node_modules/bluebird/js/main/util.js:26:23)
         │         at Promise._settlePromiseFromHandler (node_modules/bluebird/js/main/promise.js:503:31)
         │         at Promise._settlePromiseAt (node_modules/bluebird/js/main/promise.js:577:18)
         │         at Promise._settlePromises (node_modules/bluebird/js/main/promise.js:693:14)
         │         at Async._drainQueue (node_modules/bluebird/js/main/async.js:123:16)
         │         at Async._drainQueues (node_modules/bluebird/js/main/async.js:133:10)
         │         at Immediate.Async.drainQueues (node_modules/bluebird/js/main/async.js:15:14)

Not sure why that would be related, gonna try re-running.

Jenkins, test this

Bargs
Bargs suggested changes Apr 27, 2017
View reviewed changes
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed just one small issue

...agement/sections/indices/edit_index_pattern/scripted_fields_table/scripted_fields_table.html Outdated
We’ve detected that the following deprecated languages are in use: {{ getDeprecatedLanguagesInUse().join(', ') }}.
Support for these languages will be removed in the next major version of Kibana and Elasticsearch.
We recommend converting your scripted fields to
<a class="kuiLink" target="_window" ng-href="{{docLinks.painless}}">Painless</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ng-href doesn't seem to be working anymore for some reason

screen shot 2017-04-27 at 3 56 25 pm

@cjcenizal
Convert ScriptedFieldsTable and SourceFiltersTable to UI Framework co…
04e85c7 
…mponents. (elastic#11401)

* Convert ScriptedFieldsTable and SourceFiltersTable to UI Framework components.
* Remove unused Bootstrap input-group-btn class.
* Fix bug that prevented 'Create Index Pattern' button text from showing up.
@cjcenizal
Fix link to Painless documentation.
06c26c7
@cjcenizal cjcenizal force-pushed the backport/11401/5.x branch from 7dfb2d7 to 06c26c7 Compare April 27, 2017 20:20
@cjcenizal
Copy link
Contributor Author

@Bargs Fixed! Good catch. Looks like the import path was broken (https://github.com/elastic/kibana/pull/9193/files#diff-f92a33234c1ea4b5aad7362ff29fecceR9). I didn't dig too deep but I suspect this may have been caused by the migration to named exports (https://github.com/elastic/kibana/commits/master/src/ui/public/documentation_links/documentation_links.js).

Bargs
Bargs approved these changes Apr 27, 2017
View reviewed changes
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I didn't dig too deep but I suspect this may have been caused by the migration to named exports

Hmmm that's concerning. @stacey-gammon you may want to check this out in case it's an edge case your scripts could have missed elsewhere in the codebase.

@cjcenizal cjcenizal merged commit d2f39ff into elastic:5.x Apr 27, 2017
@cjcenizal cjcenizal deleted the backport/11401/5.x branch April 27, 2017 21:35
@stacey-gammon
Copy link
Contributor

stacey-gammon commented Apr 28, 2017 •
edited
Loading

Indeed, looks like that reference was missed in the refactor PR. There were no scripts @Bargs, the conversion was done by manual search/replace.

The best way to catch these issues would be to resolve #6430 and then add eslint-plugin-import.

@cjcenizal cjcenizal mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bargs Bargs Bargs approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @Bargs @stacey-gammon