Deprecation warnings for scripted fields #9193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
requested changes
Nov 23, 2016
| </h4> | ||
| <p> | ||
| <span class="text-capitalize">{{editor.field.lang}}</span> is deprecated and support will be removed in the | ||
| next major version of Kibana and Elasticsearch. We recommend using Painless for new scripted fields. |
There was a problem hiding this comment.
Linking to the Painless docs in the index-level warning is a great idea. Let's do the same here.
| $scope.getDeprecatedLanguagesInUse = function () { | ||
| const fields = $scope.indexPattern.getScriptedFields(); | ||
| const langsInUse = _.uniq(_.map(fields, 'lang')); | ||
| return _.difference(langsInUse, ['expression', 'painless']); |
There was a problem hiding this comment.
Extracting the array of supported languages into a constant somewhere would allow to reduce duplication with the field editor.
| @@ -87,6 +87,10 @@ uiModules | |||
| }); | |||
| }; | |||
|
|
|||
| self.isSupportedLang = function (lang) { | |||
| return _.contains(['expression', 'painless'], lang); | |||
There was a problem hiding this comment.
Extracting the array of supported languages into a constant somewhere would allow to reduce duplication with the scripted field list.
* Added painless doc link to field editor deprecation warning * Extracted scripting lang logic into a reuseable module * Fixed issue where deprecation warning showed on field editor page if scripting was completely disabled in ES
|
@weltenwort I've addressed your comments, ready for another look! |
|
Gonna wait to merge until we decide if #9172 will go into 5.x, cause I'd like to test them together if we do. |
|
Leaving #9172 in 6.0 only for now, so merging in 3.. 2.. 1.. 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation warnings on the scripted field list page and the scripted field creation page when languages other than
expressionandpainlessare being used.If any existing scripted fields are using a deprecated language, they'll see this warning:
If a user attempts to create a new scripted field with a deprecated language they'll see this warning:
To test you'll need to enable at least groovy in Elasticsearch. You can do this easily by modifying your esvm.js file and adding the following block to the config:
Fixes #9174