Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning #118022

Merged
merged 2 commits into from
Nov 10, 2021
Merged

[Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning #118022

merged 2 commits into from
Nov 10, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 9, 2021 •
edited
Loading

Part of: #117980

Summary

ignore_throttled was deprecated on ES side. For this reason, we will only pass ignore_throttled only if searching over frozen indices

The following code

{
  ignore_throttled: !tlConfig.settings[UI_SETTINGS.SEARCH_INCLUDE_FROZEN],
}

was replaced with

{
 ...(includeFrozen ? { ignore_throttled: false } : {}),
}

@alexwizp alexwizp mentioned this pull request Nov 9, 2021
Closed
5 tasks
@alexwizp alexwizp requested a review from rudolf November 9, 2021 15:04
@alexwizp alexwizp added v7.16.0 v8.0.0 v8.1.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Nov 9, 2021
@alexwizp alexwizp self-assigned this Nov 9, 2021
@alexwizp alexwizp added the Feature:Timelion Timelion app and visualization label Nov 9, 2021
@alexwizp alexwizp marked this pull request as ready for review November 9, 2021 15:10
@alexwizp alexwizp requested a review from a team as a code owner November 9, 2021 15:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

stratoula
stratoula approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it locally and works fine! Thanx Alex

@alexwizp alexwizp added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 10, 2021
@alexwizp alexwizp merged commit 9433346 into elastic:main Nov 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 10, 2021
@alexwizp @kibanamachine
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
3fe4526 
…ndices to avoid deprecation warning (elastic#118022)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: elastic#117980

* add tests
@kibanamachine kibanamachine mentioned this pull request Nov 10, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 10, 2021
@alexwizp @kibanamachine
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
809a905 
…ndices to avoid deprecation warning (elastic#118022)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: elastic#117980

* add tests
@kibanamachine kibanamachine mentioned this pull request Nov 10, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 10, 2021
@kibanamachine @alexwizp
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
f82874d 
…ndices to avoid deprecation warning (#118022) (#118173)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: #117980

* add tests

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine added a commit that referenced this pull request Nov 10, 2021
@kibanamachine @alexwizp
[Timelion ]Remove usage of ignore_throttled unless targeting frozen i…
7e58210 
…ndices to avoid deprecation warning (#118022) (#118172)

* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: #117980

* add tests

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
@flash1293 flash1293 mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@rudolf rudolf Awaiting requested review from rudolf

Assignees

@alexwizp alexwizp

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @elasticmachine @kibanamachine @stratoula